Merged
Conversation
added 7 commits
May 18, 2017 13:08
Contributor
Author
|
Tagging @dotnet/roslyn-ide for review |
Pilchie
approved these changes
May 18, 2017
| <DataTemplate x:Key="listViewDataTemplate"> | ||
| <StackPanel Orientation="Horizontal"> | ||
| <CheckBox x:Uid="SelectableMemberCheckBox" | ||
| IsChecked="{Binding IsChecked, Mode=TwoWay}" |
Contributor
There was a problem hiding this comment.
indentation feels weird.
Contributor
Author
There was a problem hiding this comment.
That's because it is weird.
Contributor
There was a problem hiding this comment.
Please deweird this PR.
Contributor
Author
There was a problem hiding this comment.
Deweirding complete.
CyrusNajmabadi
approved these changes
May 19, 2017
Contributor
Author
|
Tagging @MattGertz for ask mode consideration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems?id=391339&_a=edit&triage=true
Ask Mode Template
Customer scenario: A blind customer will be unable to use Naming Styles due to lack of accessibility to screen readers.
Bugs this fixes: https://devdiv.visualstudio.com/DevDiv/_workitems?id=391339&_a=edit&triage=true
Workarounds, if any None
Risk: Very low. Top-level feature, pretty straight-forward changes.
Performance impact: Essentially none.
Is this a regression from a previous update? No
Root cause analysis: This was missed during the initial feature work
How was the bug found? Accessibility test pass