Add missed code style options to automation object#16512
Merged
jmarolf merged 1 commit intodotnet:post-dev15from Feb 3, 2017
Merged
Add missed code style options to automation object#16512jmarolf merged 1 commit intodotnet:post-dev15from
jmarolf merged 1 commit intodotnet:post-dev15from
Conversation
Pilchie
approved these changes
Jan 18, 2017
Member
Pilchie
left a comment
There was a problem hiding this comment.
👍, but a couple of questions:
- What can we do to prevent this in the future
- Do we have a separate bug about updating the baseline profiles so that reset-all-settings works?
Contributor
Author
Member
|
Tagging @MattGertz does this meet the bar at this point? |
Contributor
|
I'm afraid not. Please move to 2.1, and make sure we have documentation around this. |
4a591f2 to
0f3002a
Compare
Contributor
Author
|
@dotnet/roslyn-ide please review |
jasonmalinowski
approved these changes
Feb 3, 2017
This was referenced May 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Customer scenario
Customer is unable to import or export most codestyle settings
Bugs this fixes:
#14810
Workarounds, if any
Manually reset the options on each machine, or log in and have them roam with other VS settings
Risk
Low, we are adding options to the automation object. This fix is very self-contained
Performance impact
Low, export/import of settings is an explicit user actions that has its own dialog and must be initiated by the user, it is not part of any mainline scenario
Is this a regression from a previous update?
Users have always been able to import/export all of tools->options so this is an experience regression, though these options are new so you could say these options have not been shipped before so this is not a regression.
Root cause analysis:
The Automation object class is what is reflected over by VS to import/export settings. As more codestyle settings were added this release we forgot to update the automation object.
How was the bug found?
reported by customer