Skip to content

F# inlay hints do not work with Alt-F1 momentary toggle #82614

@majocha

Description

@majocha

#67367 introduced displayAllOverride parameter but IFSharpInlineHintsService was not updated. The parameter is ignored in FSharpInlineHintsService implementation:

public async Task<ImmutableArray<InlineHint>> GetInlineHintsAsync(
Document document, TextSpan textSpan, InlineHintsOptions options, bool displayAllOverride, CancellationToken cancellationToken)
{
if (_service == null)
return [];
var hints = await _service.GetInlineHintsAsync(document, textSpan, cancellationToken).ConfigureAwait(false);
return hints.SelectAsArray(h => new InlineHint(h.Span, h.DisplayParts, (d, c) => h.GetDescriptionAsync(d, c)));
}
}

In effect F# cannot participate in the Alt-F1 momentary hints toggle and this option does not work:

Image

I propose to just update the IVT interface IFSharpInlineHintsService to pass displayAllOverride to the F# side correctly.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions