Code completion on override method doesn't apply correctly #76141
Description
Version Used:
4.13.0-2.24558.12
Steps to Reproduce:
- Use the override keyword in a class
- Select one of the suggested method
- Apply the completion
Expected Behavior:
The completion should apply with the appropriate selected method.
Actual Behavior:
The suggested methods are correct, but the completion is not. Instead of the selected method, a single character appears, or paranthesis, or none at all. This happens in:
- C# neovim Can not override methods from parent class seblyng/roslyn.nvim#72
- Razor vscode with the C# Dev Kit extension Method overload completion no offered when expect in Razor file and generated code is incorrectly formatted or missing method body microsoft/vscode-dotnettools#855 (comment)
I expect that it was fixed client-side in vscode for normal C# as it somehow seems to work in that scenario.
Attached one more example:
2024-11-29_00-05-55.mp4
From what I see relevant in the logs, the sent workspace/executeCommand is correct, but the server responds with a few exceptions:
[DEBUG][2024-11-28 19:49:56] .../vim/lsp/rpc.lua:286 "rpc.send" { jsonrpc = "2.0", method = "textDocument/didChange", params = { contentChanges = { { range = { ["end"] = { character = 14, line = 3 }, start = { character = 14, line = 3 } }, rangeLength = 0, text = "p" }, { range = { ["end"] = { character = 15, line = 3 }, start = { character = 15, line = 3 } }, rangeLength = 0, text = "e" }, { range = { ["end"] = { character = 16, line = 3 }, start = { character = 16, line = 3 } }, rangeLength = 0, text = "a" }, { range = { ["end"] = { character = 17, line = 3 }, start = { character = 17, line = 3 } }, rangeLength = 0, text = "k" }, { range = { ["end"] = { character = 18, line = 3 }, start = { character = 18, line = 3 } }, rangeLength = 0, text = "(" }, { range = { ["end"] = { character = 19, line = 3 }, start = { character = 19, line = 3 } }, rangeLength = 0, text = ")" }, { range = { ["end"] = { character = 20, line = 3 }, start = { character = 13, line = 3 } }, rangeLength = 7, text = "" }, { range = { ["end"] = { character = 13, line = 3 }, start = { character = 13, line = 3 } }, rangeLength = 0, text = "" } }, textDocument = { uri = "file:///C:/Users/bida/Desktop/testtraits/Dog.cs", version = 29 } }}
[DEBUG][2024-11-28 19:49:56] .../vim/lsp/rpc.lua:286 "rpc.send" { jsonrpc = "2.0", method = "textDocument/didChange", params = { contentChanges = { { range = { ["end"] = { character = 14, line = 3 }, start = { character = 14, line = 3 } }, rangeLength = 0, text = "p" }, { range = { ["end"] = { character = 15, line = 3 }, start = { character = 15, line = 3 } }, rangeLength = 0, text = "e" }, { range = { ["end"] = { character = 16, line = 3 }, start = { character = 16, line = 3 } }, rangeLength = 0, text = "a" }, { range = { ["end"] = { character = 17, line = 3 }, start = { character = 17, line = 3 } }, rangeLength = 0, text = "k" }, { range = { ["end"] = { character = 18, line = 3 }, start = { character = 18, line = 3 } }, rangeLength = 0, text = "(" }, { range = { ["end"] = { character = 19, line = 3 }, start = { character = 19, line = 3 } }, rangeLength = 0, text = ")" }, { range = { ["end"] = { character = 20, line = 3 }, start = { character = 13, line = 3 } }, rangeLength = 7, text = "" }, { range = { ["end"] = { character = 13, line = 3 }, start = { character = 13, line = 3 } }, rangeLength = 0, text = "" } }, textDocument = { uri = "file:///C:/Users/bida/Desktop/testtraits/Dog.cs", version = 29 } }}
[DEBUG][2024-11-28 19:49:56] ...m/lsp/client.lua:676 "LSP[roslyn]" "client.request" 1 "workspace/executeCommand" { arguments = { { uri = "file:///C:/Users/bida/Desktop/testtraits/Dog.cs" }, { newText = "\r\n public override void Speak()\r\n {\r\n base.Speak();\r\n }", range = { ["end"] = { character = 13, line = 3 }, start = { character = 49, line = 2 } } }, false, 130 }, command = "roslyn.client.completionComplexEdit", title = "CompleteComplexEditCommand"} <function 1> 3
[DEBUG][2024-11-28 19:49:56] .../vim/lsp/rpc.lua:286 "rpc.send" { id = 31, jsonrpc = "2.0", method = "workspace/executeCommand", params = { arguments = { { uri = "file:///C:/Users/bida/Desktop/testtraits/Dog.cs" }, { newText = "\r\n public override void Speak()\r\n {\r\n base.Speak();\r\n }", range = { ["end"] = { character = 13, line = 3 }, start = { character = 49, line = 2 } } }, false, 130 }, command = "roslyn.client.completionComplexEdit", title = "CompleteComplexEditCommand" }}
[DEBUG][2024-11-28 19:49:56] ...m/lsp/client.lua:676 "LSP[roslyn]" "client.request" 1 "textDocument/diagnostic" { range = { ["end"] = { character = 0, line = 5 }, start = { character = 0, line = 1 } }, textDocument = { uri = "file:///C:/Users/bida/Desktop/testtraits/Dog.cs" }} <function 1> 3
[DEBUG][2024-11-28 19:49:56] .../vim/lsp/rpc.lua:286 "rpc.send" { id = 32, jsonrpc = "2.0", method = "textDocument/diagnostic", params = { range = { ["end"] = { character = 0, line = 5 }, start = { character = 0, line = 1 } }, textDocument = { uri = "file:///C:/Users/bida/Desktop/testtraits/Dog.cs" } }}
[DEBUG][2024-11-28 19:49:56] ...m/lsp/client.lua:676 "LSP[roslyn]" "client.request" 1 "textDocument/diagnostic" { range = { ["end"] = { character = 0, line = 5 }, start = { character = 0, line = 1 } }, textDocument = { uri = "file:///C:/Users/bida/Desktop/testtraits/Dog.cs" }} <function 1> 3
[DEBUG][2024-11-28 19:49:56] .../vim/lsp/rpc.lua:286 "rpc.send" { id = 33, jsonrpc = "2.0", method = "textDocument/diagnostic", params = { range = { ["end"] = { character = 0, line = 5 }, start = { character = 0, line = 1 } }, textDocument = { uri = "file:///C:/Users/bida/Desktop/testtraits/Dog.cs" } }}
[DEBUG][2024-11-28 19:49:56] .../vim/lsp/rpc.lua:408 "rpc.receive" { jsonrpc = "2.0", method = "window/logMessage", params = { message = "[LanguageServerHost] System.InvalidOperationException: This cannot be done after listening has started.\r\n at Microsoft.Verify.FailOperation(String message)\r\n at StreamJsonRpc.JsonRpc.ThrowIfConfigurationLocked()\r\n at StreamJsonRpc.JsonRpc.AddLocalRpcMethod(MethodInfo handler, Object target, JsonRpcMethodAttribute methodRpcSettings)\r\n at Microsoft.CommonLanguageServerProtocol.Framework.AbstractLanguageServer`1.SetupRequestDispatcher(AbstractHandlerProvider handlerProvider) in /_/src/LanguageServer/Microsoft.CommonLanguageServerProtocol.Framework/AbstractLanguageServer.cs:line 136\r\n at Microsoft.CommonLanguageServerProtocol.Framework.AbstractLanguageServer`1.get_HandlerProvider() in /_/src/LanguageServer/Microsoft.CommonLanguageServerProtocol.Framework/AbstractLanguageServer.cs:line 94\r\n at Microsoft.CodeAnalysis.LanguageServer.BaseService.LazyService`1.GetInstance(ILspServices lspServices) in /_/src/LanguageServer/Protocol/LspServices/BaseService.cs:line 46\r\n at Microsoft.CodeAnalysis.LanguageServer.LspServices.GetService(String typeName) in /_/src/LanguageServer/Protocol/LspServices/LspServices.cs:line 143\r\n at Microsoft.CodeAnalysis.LanguageServer.LspServices.GetService[T]() in /_/src/LanguageServer/Protocol/LspServices/LspServices.cs:line 97\r\n at Microsoft.CodeAnalysis.LanguageServer.LspServices.GetRequiredService[T]() in /_/src/LanguageServer/Protocol/LspServices/LspServices.cs:line 90\r\n at Microsoft.CodeAnalysis.LanguageServer.Handler.ExecuteWorkspaceCommandHandler.HandleRequestAsync(ExecuteCommandParams request, RequestContext context, CancellationToken cancellationToken) in /_/src/LanguageServer/Protocol/Handler/WorkspaceCommand/ExecuteWorkspaceCommandHandler.cs:line 32\r\n at Microsoft.CommonLanguageServerProtocol.Framework.QueueItem`1.StartRequestAsync[TRequest,TResponse](TRequest request, TRequestContext context, IMethodHandler handler, String language, CancellationToken cancellationToken) in /_/src/LanguageServer/Microsoft.CommonLanguageServerProtocol.Framework/QueueItem.cs:line 191", type = 1 }}
[TRACE][2024-11-28 19:49:56] ...m/lsp/client.lua:1001 "notification" "window/logMessage" { message = "[LanguageServerHost] System.InvalidOperationException: This cannot be done after listening has started.\r\n at Microsoft.Verify.FailOperation(String message)\r\n at StreamJsonRpc.JsonRpc.ThrowIfConfigurationLocked()\r\n at StreamJsonRpc.JsonRpc.AddLocalRpcMethod(MethodInfo handler, Object target, JsonRpcMethodAttribute methodRpcSettings)\r\n at Microsoft.CommonLanguageServerProtocol.Framework.AbstractLanguageServer`1.SetupRequestDispatcher(AbstractHandlerProvider handlerProvider) in /_/src/LanguageServer/Microsoft.CommonLanguageServerProtocol.Framework/AbstractLanguageServer.cs:line 136\r\n at Microsoft.CommonLanguageServerProtocol.Framework.AbstractLanguageServer`1.get_HandlerProvider() in /_/src/LanguageServer/Microsoft.CommonLanguageServerProtocol.Framework/AbstractLanguageServer.cs:line 94\r\n at Microsoft.CodeAnalysis.LanguageServer.BaseService.LazyService`1.GetInstance(ILspServices lspServices) in /_/src/LanguageServer/Protocol/LspServices/BaseService.cs:line 46\r\n at Microsoft.CodeAnalysis.LanguageServer.LspServices.GetService(String typeName) in /_/src/LanguageServer/Protocol/LspServices/LspServices.cs:line 143\r\n at Microsoft.CodeAnalysis.LanguageServer.LspServices.GetService[T]() in /_/src/LanguageServer/Protocol/LspServices/LspServices.cs:line 97\r\n at Microsoft.CodeAnalysis.LanguageServer.LspServices.GetRequiredService[T]() in /_/src/LanguageServer/Protocol/LspServices/LspServices.cs:line 90\r\n at Microsoft.CodeAnalysis.LanguageServer.Handler.ExecuteWorkspaceCommandHandler.HandleRequestAsync(ExecuteCommandParams request, RequestContext context, CancellationToken cancellationToken) in /_/src/LanguageServer/Protocol/Handler/WorkspaceCommand/ExecuteWorkspaceCommandHandler.cs:line 32\r\n at Microsoft.CommonLanguageServerProtocol.Framework.QueueItem`1.StartRequestAsync[TRequest,TResponse](TRequest request, TRequestContext context, IMethodHandler handler, String language, CancellationToken cancellationToken) in /_/src/LanguageServer/Microsoft.CommonLanguageServerProtocol.Framework/QueueItem.cs:line 191", type = 1}
[TRACE][2024-11-28 19:49:56] ...lsp/handlers.lua:711 "default_handler" "window/logMessage" { ctx = '{\n client_id = 1,\n method = "window/logMessage"\n}', result = { message = "[LanguageServerHost] System.InvalidOperationException: This cannot be done after listening has started.\r\n at Microsoft.Verify.FailOperation(String message)\r\n at StreamJsonRpc.JsonRpc.ThrowIfConfigurationLocked()\r\n at StreamJsonRpc.JsonRpc.AddLocalRpcMethod(MethodInfo handler, Object target, JsonRpcMethodAttribute methodRpcSettings)\r\n at Microsoft.CommonLanguageServerProtocol.Framework.AbstractLanguageServer`1.SetupRequestDispatcher(AbstractHandlerProvider handlerProvider) in /_/src/LanguageServer/Microsoft.CommonLanguageServerProtocol.Framework/AbstractLanguageServer.cs:line 136\r\n at Microsoft.CommonLanguageServerProtocol.Framework.AbstractLanguageServer`1.get_HandlerProvider() in /_/src/LanguageServer/Microsoft.CommonLanguageServerProtocol.Framework/AbstractLanguageServer.cs:line 94\r\n at Microsoft.CodeAnalysis.LanguageServer.BaseService.LazyService`1.GetInstance(ILspServices lspServices) in /_/src/LanguageServer/Protocol/LspServices/BaseService.cs:line 46\r\n at Microsoft.CodeAnalysis.LanguageServer.LspServices.GetService(String typeName) in /_/src/LanguageServer/Protocol/LspServices/LspServices.cs:line 143\r\n at Microsoft.CodeAnalysis.LanguageServer.LspServices.GetService[T]() in /_/src/LanguageServer/Protocol/LspServices/LspServices.cs:line 97\r\n at Microsoft.CodeAnalysis.LanguageServer.LspServices.GetRequiredService[T]() in /_/src/LanguageServer/Protocol/LspServices/LspServices.cs:line 90\r\n at Microsoft.CodeAnalysis.LanguageServer.Handler.ExecuteWorkspaceCommandHandler.HandleRequestAsync(ExecuteCommandParams request, RequestContext context, CancellationToken cancellationToken) in /_/src/LanguageServer/Protocol/Handler/WorkspaceCommand/ExecuteWorkspaceCommandHandler.cs:line 32\r\n at Microsoft.CommonLanguageServerProtocol.Framework.QueueItem`1.StartRequestAsync[TRequest,TResponse](TRequest request, TRequestContext context, IMethodHandler handler, String language, CancellationToken cancellationToken) in /_/src/LanguageServer/Microsoft.CommonLanguageServerProtocol.Framework/QueueItem.cs:line 191", type = 1 }}
[ERROR][2024-11-28 19:49:56] ...lsp/handlers.lua:623 "[LanguageServerHost] System.InvalidOperationException: This cannot be done after listening has started.\r\n at Microsoft.Verify.FailOperation(String message)\r\n at StreamJsonRpc.JsonRpc.ThrowIfConfigurationLocked()\r\n at StreamJsonRpc.JsonRpc.AddLocalRpcMethod(MethodInfo handler, Object target, JsonRpcMethodAttribute methodRpcSettings)\r\n at Microsoft.CommonLanguageServerProtocol.Framework.AbstractLanguageServer`1.SetupRequestDispatcher(AbstractHandlerProvider handlerProvider) in /_/src/LanguageServer/Microsoft.CommonLanguageServerProtocol.Framework/AbstractLanguageServer.cs:line 136\r\n at Microsoft.CommonLanguageServerProtocol.Framework.AbstractLanguageServer`1.get_HandlerProvider() in /_/src/LanguageServer/Microsoft.CommonLanguageServerProtocol.Framework/AbstractLanguageServer.cs:line 94\r\n at Microsoft.CodeAnalysis.LanguageServer.BaseService.LazyService`1.GetInstance(ILspServices lspServices) in /_/src/LanguageServer/Protocol/LspServices/BaseService.cs:line 46\r\n at Microsoft.CodeAnalysis.LanguageServer.LspServices.GetService(String typeName) in /_/src/LanguageServer/Protocol/LspServices/LspServices.cs:line 143\r\n at Microsoft.CodeAnalysis.LanguageServer.LspServices.GetService[T]() in /_/src/LanguageServer/Protocol/LspServices/LspServices.cs:line 97\r\n at Microsoft.CodeAnalysis.LanguageServer.LspServices.GetRequiredService[T]() in /_/src/LanguageServer/Protocol/LspServices/LspServices.cs:line 90\r\n at Microsoft.CodeAnalysis.LanguageServer.Handler.ExecuteWorkspaceCommandHandler.HandleRequestAsync(ExecuteCommandParams request, RequestContext context, CancellationToken cancellationToken) in /_/src/LanguageServer/Protocol/Handler/WorkspaceCommand/ExecuteWorkspaceCommandHandler.cs:line 32\r\n at Microsoft.CommonLanguageServerProtocol.Framework.QueueItem`1.StartRequestAsync[TRequest,TResponse](TRequest request, TRequestContext context, IMethodHandler handler, String language, CancellationToken cancellationToken) in /_/src/LanguageServer/Microsoft.CommonLanguageServerProtocol.Framework/QueueItem.cs:line 191"
[DEBUG][2024-11-28 19:49:56] .../vim/lsp/rpc.lua:408 "rpc.receive" { error = { code = -32000, data = { code = -2146233079, message = "This cannot be done after listening has started.", stack = " at Microsoft.Verify.FailOperation(String message)\r\n at StreamJsonRpc.JsonRpc.ThrowIfConfigurationLocked()\r\n at StreamJsonRpc.JsonRpc.AddLocalRpcMethod(MethodInfo handler, Object target, JsonRpcMethodAttribute methodRpcSettings)\r\n at Microsoft.CommonLanguageServerProtocol.Framework.AbstractLanguageServer`1.SetupRequestDispatcher(AbstractHandlerProvider handlerProvider) in /_/src/LanguageServer/Microsoft.CommonLanguageServerProtocol.Framework/AbstractLanguageServer.cs:line 136\r\n at Microsoft.CommonLanguageServerProtocol.Framework.AbstractLanguageServer`1.get_HandlerProvider() in /_/src/LanguageServer/Microsoft.CommonLanguageServerProtocol.Framework/AbstractLanguageServer.cs:line 94\r\n at Microsoft.CodeAnalysis.LanguageServer.BaseService.LazyService`1.GetInstance(ILspServices lspServices) in /_/src/LanguageServer/Protocol/LspServices/BaseService.cs:line 46\r\n at Microsoft.CodeAnalysis.LanguageServer.LspServices.GetService(String typeName) in /_/src/LanguageServer/Protocol/LspServices/LspServices.cs:line 143\r\n at Microsoft.CodeAnalysis.LanguageServer.LspServices.GetService[T]() in /_/src/LanguageServer/Protocol/LspServices/LspServices.cs:line 97\r\n at Microsoft.CodeAnalysis.LanguageServer.LspServices.GetRequiredService[T]() in /_/src/LanguageServer/Protocol/LspServices/LspServices.cs:line 90\r\n at Microsoft.CodeAnalysis.LanguageServer.Handler.ExecuteWorkspaceCommandHandler.HandleRequestAsync(ExecuteCommandParams request, RequestContext context, CancellationToken cancellationToken) in /_/src/LanguageServer/Protocol/Handler/WorkspaceCommand/ExecuteWorkspaceCommandHandler.cs:line 32\r\n at Microsoft.CommonLanguageServerProtocol.Framework.QueueItem`1.StartRequestAsync[TRequest,TResponse](TRequest request, TRequestContext context, IMethodHandler handler, String language, CancellationToken cancellationToken) in /_/src/LanguageServer/Microsoft.CommonLanguageServerProtocol.Framework/QueueItem.cs:line 191\r\n at Microsoft.CommonLanguageServerProtocol.Framework.AbstractLanguageServer`1.DelegatingEntryPoint.InvokeAsync(IRequestExecutionQueue`1 queue, Object requestObject, ILspServices lspServices, CancellationToken cancellationToken) in /_/src/LanguageServer/Microsoft.CommonLanguageServerProtocol.Framework/AbstractLanguageServer.cs:line 204\r\n at Microsoft.CommonLanguageServerProtocol.Framework.SystemTextJsonLanguageServer`1.SystemTextJsonDelegatingEntryPoint.ExecuteRequestAsync(Nullable`1 request, CancellationToken cancellationToken) in /_/src/LanguageServer/Microsoft.CommonLanguageServerProtocol.Framework/SystemTextJsonLanguageServer.cs:line 88", type = "System.InvalidOperationException" }, message = "This cannot be done after listening has started." }, id = 31, jsonrpc = "2.0"}
[DEBUG][2024-11-28 19:49:56] .../vim/lsp/rpc.lua:286 "rpc.send" { jsonrpc = "2.0", method = "textDocument/didChange", params = { contentChanges = { { range = { ["end"] = { character = 13, line = 3 }, start = { character = 13, line = 3 } }, rangeLength = 0, text = "(" }, { range = { ["end"] = { character = 14, line = 3 }, start = { character = 14, line = 3 } }, rangeLength = 0, text = ")" } }, textDocument = { uri = "file:///C:/Users/bida/Desktop/testtraits/Dog.cs", version = 31 } }}
[DEBUG][2024-11-28 19:49:56] .../vim/lsp/rpc.lua:286 "rpc.send" { jsonrpc = "2.0", method = "textDocument/didChange", params = { contentChanges = { { range = { ["end"] = { character = 13, line = 3 }, start = { character = 13, line = 3 } }, rangeLength = 0, text = "(" }, { range = { ["end"] = { character = 14, line = 3 }, start = { character = 14, line = 3 } }, rangeLength = 0, text = ")" } }, textDocument = { uri = "file:///C:/Users/bida/Desktop/testtraits/Dog.cs", version = 31 } }}
[DEBUG][2024-11-28 19:49:56] ...m/lsp/client.lua:676 "LSP[roslyn]" "client.request" 1 "textDocument/completion" { context = { triggerCharacter = "(", triggerKind = 2 }, position = { character = 14, line = 3 }, textDocument = { uri = "file:///C:/Users/bida/Desktop/testtraits/Dog.cs" }} <function 1> 3
[DEBUG][2024-11-28 19:49:56] .../vim/lsp/rpc.lua:286 "rpc.send" { id = 34, jsonrpc = "2.0", method = "textDocument/completion", params = { context = { triggerCharacter = "(", triggerKind = 2 }, position = { character = 14, line = 3 }, textDocument = { uri = "file:///C:/Users/bida/Desktop/testtraits/Dog.cs" } }}
[DEBUG][2024-11-28 19:49:56] ...m/lsp/client.lua:676 "LSP[roslyn]" "client.request" 1 "textDocument/signatureHelp" { position = { character = 14, line = 3 }, textDocument = { uri = "file:///C:/Users/bida/Desktop/testtraits/Dog.cs" }} <function 1> 3
[DEBUG][2024-11-28 19:49:56] .../vim/lsp/rpc.lua:286 "rpc.send" { id = 35, jsonrpc = "2.0", method = "textDocument/signatureHelp", params = { position = { character = 14, line = 3 }, textDocument = { uri = "file:///C:/Users/bida/Desktop/testtraits/Dog.cs" } }}
[DEBUG][2024-11-28 19:49:56] ...m/lsp/client.lua:676 "LSP[roslyn]" "client.request" 1 "textDocument/diagnostic" { range = { ["end"] = { character = 0, line = 5 }, start = { character = 0, line = 1 } }, textDocument = { uri = "file:///C:/Users/bida/Desktop/testtraits/Dog.cs" }} <function 1> 3
[DEBUG][2024-11-28 19:49:56] .../vim/lsp/rpc.lua:286 "rpc.send" { id = 36, jsonrpc = "2.0", method = "textDocument/diagnostic", params = { range = { ["end"] = { character = 0, line = 5 }, start = { character = 0, line = 1 } }, textDocument = { uri = "file:///C:/Users/bida/Desktop/testtraits/Dog.cs" } }}
[DEBUG][2024-11-28 19:49:56] .../vim/lsp/rpc.lua:408 "rpc.receive" { id = 34, jsonrpc = "2.0"}
[DEBUG][2024-11-28 19:49:56] .../vim/lsp/rpc.lua:408 "rpc.receive" { id = 35, jsonrpc = "2.0"}
[DEBUG][2024-11-28 19:49:56] ...m/lsp/client.lua:676 "LSP[roslyn]" "client.request" 1 "textDocument/signatureHelp" { position = { character = 14, line = 3 }, textDocument = { uri = "file:///C:/Users/bida/Desktop/testtraits/Dog.cs" }} <function 1> 3
[DEBUG][2024-11-28 19:49:56] .../vim/lsp/rpc.lua:286 "rpc.send" { id = 37, jsonrpc = "2.0", method = "textDocument/signatureHelp", params = { position = { character = 14, line = 3 }, textDocument = { uri = "file:///C:/Users/bida/Desktop/testtraits/Dog.cs" } }}
[DEBUG][2024-11-28 19:49:56] .../vim/lsp/rpc.lua:408 "rpc.receive" { id = 37, jsonrpc = "2.0"}