Skip to content

OrganizeImportsTests involving non-English characters are failing locally. #58834

@Youssef1313

Description

@Youssef1313

Version Used:

main

Steps to Reproduce:

Run Build.cmd -testCoreClr locally.

Actual Behavior:

image

Expected Behavior:

No test failure. The code path for comparing appears to be using InvariantCulture, which per documentation:

invariant culture data is stable over time and across installed cultures and cannot be customized by users. This makes the invariant culture particularly useful for operations that require culture-independent results, such as formatting and parsing operations that persist formatted data, or sorting and ordering operations that require that data be displayed in a fixed order regardless of culture.

StackOverflow question around this area for reference.

The comparison, per my understanding, happens in:

https://github.com/dotnet/roslyn/blob/main/src/Workspaces/SharedUtilitiesAndExtensions/Compiler/CSharp/Utilities/TokenComparer.cs

https://github.com/dotnet/roslyn/blob/main/src/Workspaces/SharedUtilitiesAndExtensions/Compiler/VisualBasic/Utilities/TokenComparer.vb

Metadata

Metadata

Assignees

Labels

Area-IDETestTest failures in roslyn-CI

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions