Skip to content

Additional PROTOTYPE comments for param-nullchecking #58335

Closed
Closed
Additional PROTOTYPE comments for param-nullchecking#58335
Assignees
RikkiGibson
Labels
Area-CompilersBugFeature - Param Null Checking
Milestone
17.3
@RikkiGibson

Description

@RikkiGibson
RikkiGibson
opened on Dec 15, 2021

roslyn/src/Compilers/Core/Portable/Operations/ControlFlowGraphBuilder.cs

Line 1484 in 96698d9

// PROTOTYPE(param-nullchecking): this implementation doesn't handle record primary constructors

roslyn/src/Compilers/Core/Portable/Operations/ControlFlowGraphBuilder.cs

Line 1505 in 96698d9

// PROTOTYPE(param-nullchecking): do we need to use SemanticModel here?

roslyn/src/Compilers/Core/Portable/Operations/ControlFlowGraphBuilder.cs

Line 1521 in 96698d9

// PROTOTYPE(param-nullchecking): do we need to use SemanticModel here?

roslyn/src/Compilers/Core/Portable/Operations/ControlFlowGraphBuilder.cs

Line 1539 in 96698d9

// PROTOTYPE(param-nullchecking): is there a better way to get the HasValue symbol here?

roslyn/src/Compilers/CSharp/Portable/Lowering/SyntheticBoundNodeFactory.cs

Line 1601 in 96698d9

// PROTOTYPE(param-nullchecking): consider restoring the 'private' accessibility of 'static LocalRewriter.UnsafeGetNullableMethod()'

roslyn/src/Compilers/CSharp/Portable/Lowering/SyntheticBoundNodeFactory.cs

Line 1676 in 96698d9

// PROTOTYPE(BangBang): Re-enable annotations

roslyn/src/Compilers/CSharp/Portable/Parser/LanguageParser.cs

Line 11543 in 96698d9

// PROTOTYPE(BangBang): https://github.com/dotnet/roslyn/pull/46520#discussion_r466650228

roslyn/src/Compilers/CSharp/Portable/Symbols/Source/ParameterHelpers.cs

Line 792 in 81e44e1

// PROTOTYPE(param-nullchecking): consider whether we should adjust the set of locations where we call this

roslyn/src/Compilers/CSharp/Portable/Symbols/Source/ParameterHelpers.cs

Line 800 in 81e44e1

// PROTOTYPE(param-nullchecking): can we simplify with the other overload?

roslyn/src/Compilers/CSharp/Test/IOperation/IOperation/IOperationTests_NullCheckedParameters.cs

Line 2411 in 897223b

[Fact(Skip = "PROTOTYPE(param-nullchecking): MakeMemberMissing doesn't work as expected with our method of obtaining Nullable<T>.HasValue in this scenario")]

roslyn/src/Compilers/CSharp/Test/Semantic/Semantics/NullCheckedParameterTests.cs

Line 283 in 81e44e1

[Fact(Skip = "PROTOTYPE(BangBang)")]

Metadata

Metadata

Assignees

Labels

Area-CompilersBugFeature - Param Null Checking

Type

No type

Fields

No fields configured for issues without a type.

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions