-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Suggest names for matching parameters from overloads #52534
Copy link
Copy link
Closed
Labels
4 - In ReviewA fix for the issue is submitted for review.A fix for the issue is submitted for review.Area-IDEConcept-Continuous ImprovementIDE-IntelliSenseCompletion, Signature Help, Quick InfoCompletion, Signature Help, Quick InfoIntelliSense-Completionhelp wantedThe issue is "up for grabs" - add a comment if you are interested in working on itThe issue is "up for grabs" - add a comment if you are interested in working on it
Milestone
Metadata
Metadata
Assignees
Labels
4 - In ReviewA fix for the issue is submitted for review.A fix for the issue is submitted for review.Area-IDEConcept-Continuous ImprovementIDE-IntelliSenseCompletion, Signature Help, Quick InfoCompletion, Signature Help, Quick InfoIntelliSense-Completionhelp wantedThe issue is "up for grabs" - add a comment if you are interested in working on itThe issue is "up for grabs" - add a comment if you are interested in working on it
Type
Fields
Give feedbackNo fields configured for issues without a type.
The naming suggestions for parameters should include names appearing for matching types in overloads. For example, the following parameters are all representing the same data, but appearing with three different names:
sessionName:roslyn/src/Compilers/Shared/BuildClient.cs
Line 212 in 5509233
sessionKey:roslyn/src/Compilers/Shared/BuildClient.cs
Line 272 in 5509233
pipeName:roslyn/src/Compilers/Shared/BuildClient.cs
Line 284 in 5509233
Suggesting parameter names from overloads according to matching types (while accounting for the Async Pattern and Template Method Pattern naming conventions) would help avoid these mismatches.
Related to #52505