Skip to content

Incorrect namespace in Features core layer #49239

@Youssef1313

Description

@Youssef1313
  • https://github.com/dotnet/roslyn/blob/cf55f3a58e47298426fa971d3bd9d8857c746c65/src/Features/Core/Portable/ConvertAnonymousTypeToClass/AbstractConvertAnonymousTypeToClassCodeRefactoringProvider.cs#L27 (Done)

    This is the language-agnostic layer, namespaces shouldn't contain "CSharp" or "VisualBasic".

    Noted that while looking at the VB-specific code.

  • https://github.com/dotnet/roslyn/blob/03c34759fc1cbb1771967f27a7e25d79cece69af/src/Features/VisualBasic/Portable/ConvertAnonymousTypeToClass/VisualBasicConvertAnonymousTypeToClassCodeRefactoringProvider.vb#L8 (Done)

  • https://github.com/dotnet/roslyn/blob/87bd913b9edb92dec0b2ec2f3bdac48b263610bb/src/Features/Core/Portable/Completion/Providers/AbstractPreprocessorCompletionProvider.cs#L15-L17 (Done)

  • This one is very confusing:

    namespace Microsoft.CodeAnalysis.Editor.CSharp.InlineRename
    {
    [ExportLanguageService(typeof(IEditorInlineRenameService), LanguageNames.VisualBasic), Shared]
    internal class VisualBasicEditorInlineRenameService : AbstractEditorInlineRenameService

    • Namespace: CSharp
    • Implementation: VisualBasic
      -Layer: language-agnostic

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions