I think we have few proposals here:

Replace IInvocationOperation.Instance with IInvocationOperation.MemberReference, which is obviously a breaking change for analyzers on 2.6 API, hence likely least preferable.
Mark IInvocationOperation.Instance as deprecated and add a new property IMemberReferenceOperation MemberReference { get; } to IInvocationOperation. Current analyzers should work, but analyzers written on newer API can easily be moved to new API. Analyzers that register for OperationKind.MethodReference will now get callbacks for method references in invocation and non-invocation context. This could be a semantic break for analyzers, but might be for the general goodness/intuitiveness of analyzer authors.
Aleksey's proposal that IInvocationOperation just implement IMemberReferenceOperation. No API or semantic breaking change for analyzers, but analyzer authors have to register both OperationKind.MethodReference and OperationKind.Invocation to get all IMemberReferenceOperation that reference or invoke a method.

I think our general view is 3. is probably our best option, especially given analyzer authors will quickly figure out that registering just for OperationKind.MethodReference will not help them for invocation contexts.

IInvocationOperation and IObjectCreationOperation should expose the underlying IMethodReferenceOperation #26206

Description

Metadata

Metadata

Assignees

Labels

Type

Fields

Projects

Milestone

Relationships

Development

Issue actions