-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Closed
Labels
Area-CompilersResolution-FixedThe bug has been fixed and/or the requested behavior has been implementedThe bug has been fixed and/or the requested behavior has been implementedTestTest failures in roslyn-CITest failures in roslyn-CI
Milestone
Description
Currently CompileAndVerify (src/Test/Utilities/Portable/CommonTestBase.cs, line 126) automatically skips PE verification if the compilation has unsafe flag. We should tighten this and identify individual tests for unsafe code that should skip PE verification.
if (verify)
{
// Unsafe code might not verify, so don't try.
var csharpOptions = compilation.Options as CSharp.CSharpCompilationOptions;
verify = (csharpOptions == null || !csharpOptions.AllowUnsafe);
}Tagging @VSadov
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Area-CompilersResolution-FixedThe bug has been fixed and/or the requested behavior has been implementedThe bug has been fixed and/or the requested behavior has been implementedTestTest failures in roslyn-CITest failures in roslyn-CI