Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dotnet/roslyn
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 87fe251
Choose a base ref
...
head repository: dotnet/roslyn
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 5b9a9d4
Choose a head ref
  • 19 commits
  • 574 files changed
  • 4 contributors

Commits on May 18, 2022

  1. Make async

    @CyrusNajmabadi
    CyrusNajmabadi committed May 18, 2022
    Configuration menu
    Copy the full SHA
    f3fd402 View commit details
    Browse the repository at this point in the history

  2. Test fallout

    @CyrusNajmabadi
    CyrusNajmabadi committed May 18, 2022
    Configuration menu
    Copy the full SHA
    5fbb388 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/main' into extractMethodAsync

    @CyrusNajmabadi
    CyrusNajmabadi committed May 18, 2022
    Configuration menu
    Copy the full SHA
    fc0d10f View commit details
    Browse the repository at this point in the history

  4. restore file

    @CyrusNajmabadi
    CyrusNajmabadi committed May 18, 2022
    Configuration menu
    Copy the full SHA
    50edd43 View commit details
    Browse the repository at this point in the history

  5. Minor simplification to rename code

    @CyrusNajmabadi
    CyrusNajmabadi committed May 18, 2022
    Configuration menu
    Copy the full SHA
    c591fcc View commit details
    Browse the repository at this point in the history

  6. Merge pull request #61379 from CyrusNajmabadi/renameSimplification 

    Minor simplification to rename code
    @CyrusNajmabadi
    CyrusNajmabadi authored May 18, 2022
    Configuration menu
    Copy the full SHA
    f7b944d View commit details
    Browse the repository at this point in the history

  7. Merge remote-tracking branch 'upstream/main' into extractMethodAsync

    @CyrusNajmabadi
    CyrusNajmabadi committed May 18, 2022
    Configuration menu
    Copy the full SHA
    5d39a03 View commit details
    Browse the repository at this point in the history

  8. Remaining fallback options (#60888) 

    * Add missing fallbacks

* Fallback options from ILegacyGlobalOptionsWorkspaceService

* Pass options to CodeCleaner APIs.

* Fallback options from ILegacyGlobalOptionsWorkspaceService 2

* Fallback in tests

* CodeModel

* Remove CodeActionOptions.Default

* Remove dependency on IGlobalOptionService from inline hints service

* Remove obsolete VS UnitTesting APIs.

* Remote dependency on IGlobalOption service from RemoteProcessTelemetryService

* Remove ExportGlobalOptionProviderAttribute

* Remove PythiaOptions

* Remove DiagnosticOptions from solution snapshot

* Access options via AnalyzerOptionsProvider

* Split ISyntaxFormatting.cs

* Simplify initializers

* Fix

* Move AddImportPlacementOptions to a separate file in compiler extensions

* Move option providers to workspace extensions

* Move CodeCleanupOptions and IdeAnalyzerOptions to workspace extensions

* Layering

* Replace legacy GetOptions with AnalyzerOptionsProvider; add missing options

* Parameter rename, comment

* Add LineFormattingOptionsProviders

* CodeFixOptionsProvider, include CodeStyleOptions in CodeActionOptions, include LineFormattingOptions in ExtractMethodGenerationOptions

* DocumentFormattingOptions

* Move a couple of options from IdeCodeStyle to SyntaxFormatting to make them available to new document formatter

* Generalize using placement option in AddImportPlacementOptions

* Move PreferParameterNullChecking and AllowEmbeddedStatementsOnSameLine to CSharpSimplifierOptions

* Move CodeGen options to compiler extensions

* UseExpressionBody

* Eliminate more calls to Document.GetOptionsAsync

* Cleanup DocumentationCommentOptions

* Line formatting options

* DefaultConditionalExpressionWrappingLength

* insert_final_newline

* Add PreferThrowExpression to simplifier options

* Add AddNullChecksToConstructorsGeneratedFromMembers to CodeGenOptions

* GenerateEqualsAndGetHashCodeFromMembersOptions

* IImplementInterfaceService

* AddParameterCheckCodeRefactoringProvider

* ReplaceMethodWithPropertyService

* NamingStylePreferences

* Eliminate legacy option helpers

* Fix up ExtractMethod options

* Remove SyntaxFormattingOptions ctors

* Replace extra helpers with CodeFixOptionsProvider

* PreferUtf8StringLiterals

* RazorLineFormattingOptionsStorage

* Remove usage of Document.GetOptionsAsync - 1

* Remove internal usage of DocumentOptionSet and Document.GetOptionsAsync

* Simplify and unify option definition patterns

* Fixes and pattern unification

* Serialization and equality

* Simplify

* Rename

* Fixes

* CompletionOption fixes

* Feedback
    @tmat
    tmat authored May 18, 2022
    Configuration menu
    Copy the full SHA
    bb11cf4 View commit details
    Browse the repository at this point in the history

  9. Single switch

    @CyrusNajmabadi
    CyrusNajmabadi committed May 18, 2022
    Configuration menu
    Copy the full SHA
    a33f488 View commit details
    Browse the repository at this point in the history

  10. Add extract method test

    @CyrusNajmabadi
    CyrusNajmabadi committed May 18, 2022
    Configuration menu
    Copy the full SHA
    6b4769b View commit details
    Browse the repository at this point in the history

  11. Add workitem

    @CyrusNajmabadi
    CyrusNajmabadi committed May 18, 2022
    Configuration menu
    Copy the full SHA
    1b2d095 View commit details
    Browse the repository at this point in the history

  12. Merge remote-tracking branch 'upstream/main' into extractMethodAsync

    @CyrusNajmabadi
    CyrusNajmabadi committed May 18, 2022
    Configuration menu
    Copy the full SHA
    14cf228 View commit details
    Browse the repository at this point in the history

  13. Fix

    @CyrusNajmabadi
    CyrusNajmabadi committed May 18, 2022
    Configuration menu
    Copy the full SHA
    eb01dde View commit details
    Browse the repository at this point in the history

  14. Merge pull request #61386 from CyrusNajmabadi/extractMethodTest 

    Add extract method test
    @CyrusNajmabadi
    CyrusNajmabadi authored May 18, 2022
    Configuration menu
    Copy the full SHA
    95dd7d4 View commit details
    Browse the repository at this point in the history

  15. Merge pull request #61375 from CyrusNajmabadi/extractMethodAsync 

    Make the extract-method command async (using the background work indicator).
    @CyrusNajmabadi
    CyrusNajmabadi authored May 18, 2022
    Configuration menu
    Copy the full SHA
    67e035e View commit details
    Browse the repository at this point in the history

Commits on May 19, 2022

  1. Verifying interpolation escaping of curlies in content (#61387)

    @CyrusNajmabadi
    CyrusNajmabadi authored May 19, 2022
    Configuration menu
    Copy the full SHA
    78ca853 View commit details
    Browse the repository at this point in the history

  2. Verify classification on var pattern (#61376)

    @jcouv
    jcouv authored May 19, 2022
    Configuration menu
    Copy the full SHA
    dc2c23d View commit details
    Browse the repository at this point in the history

  3. Add lambda parameters in scope in nameof using proper binder (#61382)

    @jcouv
    jcouv authored May 19, 2022
    Configuration menu
    Copy the full SHA
    d7d1d04 View commit details
    Browse the repository at this point in the history

  4. Parse unchecked gracefully in operators (#61309)

    @jcouv
    jcouv authored May 19, 2022
    Configuration menu
    Copy the full SHA
    5b9a9d4 View commit details
    Browse the repository at this point in the history
Loading