Use a ThrowingTraceListener in GenerateFilteredReferenceAssembliesTask (#83076)

RikkiGibson · web-flow · commit e3a102fb75ef · 2026-04-09T19:12:46.000Z
diff --git a/src/Compilers/Shared/ThrowingTraceListener.cs b/src/Compilers/Shared/ThrowingTraceListener.cs
@@ -1,11 +1,11 @@
-﻿// Licensed to the .NET Foundation under one or more agreements.
+// Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
 using System;
 using System.Diagnostics;
 
-namespace Microsoft.CodeAnalysis.Remote;
+namespace Microsoft.CodeAnalysis;
 
 internal sealed class ThrowingTraceListener : TraceListener
 {
diff --git a/src/Compilers/Test/Core/Microsoft.CodeAnalysis.Test.Utilities.csproj b/src/Compilers/Test/Core/Microsoft.CodeAnalysis.Test.Utilities.csproj
@@ -90,6 +90,7 @@
     <Compile Include="..\..\..\Workspaces\SharedUtilitiesAndExtensions\Compiler\Core\Extensions\ControlFlowRegionExtensions.cs" Link="Compilation\FlowAnalysis\ControlFlowRegionExtensions.cs" />
     <Compile Include="..\..\..\Workspaces\SharedUtilitiesAndExtensions\Compiler\Core\FlowAnalysis\CustomDataFlowAnalysis.cs" Link="Compilation\FlowAnalysis\CustomDataFlowAnalysis.cs" />
     <Compile Include="..\..\..\Workspaces\SharedUtilitiesAndExtensions\Compiler\Core\FlowAnalysis\DataFlowAnalyzer.cs" Link="Compilation\FlowAnalysis\DataFlowAnalyzer.cs" />
+    <Compile Include="..\..\..\Compilers\Shared\ThrowingTraceListener.cs" Link="ThrowingTraceListener.cs" />
   </ItemGroup>
   <ItemGroup>
     <EmbeddedResource Update="TestResource.resx" GenerateSource="true" />
diff --git a/src/Compilers/Test/Core/ThrowingTraceListener.cs b/src/Compilers/Test/Core/ThrowingTraceListener.cs
diff --git a/src/Tools/SemanticSearch/BuildTask/GenerateFilteredReferenceAssembliesTask.cs b/src/Tools/SemanticSearch/BuildTask/GenerateFilteredReferenceAssembliesTask.cs
@@ -18,7 +18,6 @@
 using Microsoft.Build.Framework;
 using Microsoft.Build.Utilities;
 using Microsoft.CodeAnalysis.CSharp;
-using Roslyn.Utilities;
 
 namespace Microsoft.CodeAnalysis.Tools;
 
@@ -73,6 +72,10 @@ public sealed class GenerateFilteredReferenceAssembliesTask : Task
 
     public override bool Execute()
     {
+        // Ensure that debug assertion failures throw an exception instead of crashing the process
+        Trace.Listeners.Clear();
+        Trace.Listeners.Add(new ThrowingTraceListener());
+
 #if !NET
         // https://github.com/dotnet/roslyn/issues/82006
         AppDomain.CurrentDomain.AssemblyResolve += (sender, args) =>
diff --git a/src/Tools/SemanticSearch/BuildTask/SemanticSearch.BuildTask.csproj b/src/Tools/SemanticSearch/BuildTask/SemanticSearch.BuildTask.csproj
@@ -13,6 +13,9 @@
     <ProjectReference Include="..\..\..\Compilers\Core\Portable\Microsoft.CodeAnalysis.csproj" Private="true" />
     <ProjectReference Include="..\..\..\Compilers\CSharp\Portable\Microsoft.CodeAnalysis.CSharp.csproj" Private="true" />
   </ItemGroup>
+  <ItemGroup>
+    <Compile Include="..\..\..\Compilers\Shared\ThrowingTraceListener.cs" Link="ThrowingTraceListener.cs" />
+  </ItemGroup>
   <ItemGroup>
     <InternalsVisibleTo Include="SemanticSearch.BuildTask.UnitTests" />
   </ItemGroup>
diff --git a/src/Workspaces/Remote/ServiceHub/Microsoft.CodeAnalysis.Remote.ServiceHub.csproj b/src/Workspaces/Remote/ServiceHub/Microsoft.CodeAnalysis.Remote.ServiceHub.csproj
@@ -37,6 +37,7 @@
     <Compile Include="..\..\..\VisualStudio\Core\Def\Storage\FileDownloader.cs" Link="Host\Storage\FileDownloader.cs" />
     <Compile Include="..\..\..\VisualStudio\Core\Def\Telemetry\AbstractWorkspaceTelemetryService.cs" Link="Services\ProcessTelemetry\AbstractWorkspaceTelemetryService.cs" />
     <Compile Include="..\..\..\VisualStudio\Core\Def\Telemetry\Shared\*.cs" LinkBase="Services\ProcessTelemetry" />
+    <Compile Include="..\..\..\Compilers\Shared\ThrowingTraceListener.cs" Link="Host\ThrowingTraceListener.cs" />
   </ItemGroup>
   <ItemGroup>
     <RestrictedInternalsVisibleTo Include="Microsoft.CodeAnalysis.LiveUnitTesting.BuildManager" Partner="UnitTesting" Key="$(UnitTestingKey)" />
