Workaround for #32100 in Dispose analyzer

mavasani · mavasani · commit a08f86e3d5ec · 2019-06-25T07:13:59.000-07:00
Workaround for #32100 for Dev16.2
diff --git a/src/EditorFeatures/CSharpTest/DisposeAnalysis/DisposeObjectsBeforeLosingScopeTests.cs b/src/EditorFeatures/CSharpTest/DisposeAnalysis/DisposeObjectsBeforeLosingScopeTests.cs
@@ -5024,6 +5024,37 @@ void M1()
 }");
         }
 
+        [Fact, WorkItem(32100, "https://github.com/dotnet/roslyn/issues/32100")]
+        public async Task UsingDeclaration()
+        {
+            await TestDiagnosticsAsync(@"
+using System;
+class C : IDisposable
+{
+    public void Dispose() { }
+    void M1()
+    {
+        [|using var c = new C()|];
+    }
+}", parseOptions: CSharpParseOptions.Default.WithLanguageVersion(LanguageVersion.Preview));
+        }
+
+        [Fact, WorkItem(32100, "https://github.com/dotnet/roslyn/issues/32100")]
+        public async Task UsingDeclarationWithInitializer()
+        {
+            await TestDiagnosticsAsync(@"
+using System;
+class C : IDisposable
+{
+    public int P { get; set; }
+    public void Dispose() { }
+    void M1()
+    {
+        [|using var c = new C() { P = 1 }|];
+    }
+}", parseOptions: CSharpParseOptions.Default.WithLanguageVersion(LanguageVersion.Preview));
+        }
+
         [Fact]
         public async Task MissingDisposeInMethodWithAttributes()
         {
diff --git a/src/Features/Core/Portable/DisposeAnalysis/DisposeObjectsBeforeLosingScopeDiagnosticAnalyzer.cs b/src/Features/Core/Portable/DisposeAnalysis/DisposeObjectsBeforeLosingScopeDiagnosticAnalyzer.cs
@@ -103,6 +103,13 @@ private void PerformFlowAnalysisOnOperationBlock(
                     ComputeDiagnostics(disposeDataAtExit, notDisposedDiagnostics, mayBeNotDisposedDiagnostics,
                         disposeAnalysisResult, pointsToAnalysisResult);
 
+                    if (disposeAnalysisResult.ControlFlowGraph.OriginalOperation.HasAnyOperationDescendant(o => o.Kind == OperationKind.None))
+                    {
+                        // Workaround for https://github.com/dotnet/roslyn/issues/32100
+                        // Bail out in presence of OperationKind.None - not implemented IOperation.
+                        return;
+                    }
+
                     // Report diagnostics preferring *not* disposed diagnostics over may be not disposed diagnostics
                     // and avoiding duplicates.
                     foreach (var diagnostic in notDisposedDiagnostics.Concat(mayBeNotDisposedDiagnostics))
