One more test

Julien Couvreur · Julien Couvreur · commit 59b3c0ec0770 · 2020-01-22T16:25:02.000-08:00
diff --git a/src/Compilers/CSharp/Test/Semantic/Semantics/NullableReferenceTypesTests.cs b/src/Compilers/CSharp/Test/Semantic/Semantics/NullableReferenceTypesTests.cs
@@ -29645,9 +29645,14 @@ static bool TryGetValue4([NotNull] TYPE x, [NotNullWhen(false)] out TYPE y)
     {
         return TryGetValue4(x, out y);
     }
+
+    static bool TryGetValueString1(string key, [MaybeNullWhen(false)] out string value)
+        => TryGetValueString2(key, out value);
+    static bool TryGetValueString2(string key, [NotNullWhen(true)] out string? value)
+        => TryGetValueString1(key, out value);
 }
 ";
-            var comp = CreateNullableCompilation(new[] { NotNullAttributeDefinition, NotNullWhenAttributeDefinition, source.Replace("TYPE", type) });
+            var comp = CreateNullableCompilation(new[] { MaybeNullWhenAttributeDefinition, NotNullAttributeDefinition, NotNullWhenAttributeDefinition, source.Replace("TYPE", type) });
             comp.VerifyDiagnostics(
                 // (17,9): warning CS8762: Parameter 'y' may not have a null value when exiting with 'true'.
                 //         return TryGetValue3(out y); // 1

Original file line number	Diff line number	Diff line change
`@@ -29645,9 +29645,14 @@ static bool TryGetValue4([NotNull] TYPE x, [NotNullWhen(false)] out TYPE y)`
`29645`	`29645`	`{`
`29646`	`29646`	`return TryGetValue4(x, out y);`
`29647`	`29647`	`}`
	`29648`	`+`
	`29649`	`+ static bool TryGetValueString1(string key, [MaybeNullWhen(false)] out string value)`
	`29650`	`+ => TryGetValueString2(key, out value);`
	`29651`	`+ static bool TryGetValueString2(string key, [NotNullWhen(true)] out string? value)`
	`29652`	`+ => TryGetValueString1(key, out value);`
`29648`	`29653`	`}`
`29649`	`29654`	`";`
`29650`		`- var comp = CreateNullableCompilation(new[] { NotNullAttributeDefinition, NotNullWhenAttributeDefinition, source.Replace("TYPE", type) });`
	`29655`	`+ var comp = CreateNullableCompilation(new[] { MaybeNullWhenAttributeDefinition, NotNullAttributeDefinition, NotNullWhenAttributeDefinition, source.Replace("TYPE", type) });`
`29651`	`29656`	`comp.VerifyDiagnostics(`
`29652`	`29657`	`// (17,9): warning CS8762: Parameter 'y' may not have a null value when exiting with 'true'.`
`29653`	`29658`	`// return TryGetValue3(out y); // 1`