This repository was archived by the owner on Sep 26, 2024. It is now read-only.
Merged
Conversation
Member
Author
|
@dotnet/razor-compiler for review please |
333fred
approved these changes
Aug 11, 2022
RikkiGibson
approved these changes
Aug 11, 2022
Member
|
@chsienki - How does this flow into the SDK repo? I see the SDK depends on a version from July. I also noticed the SDK's razor-compiler dependencies are on multiple versions/commits (https://github.com/dotnet/sdk/blob/main/eng/Version.Details.xml#L218 and https://github.com/dotnet/sdk/blob/main/eng/Version.Details.xml#L214) which isn't good. |
Member
Author
|
@MichaelSimons turns out the CI was failing due to component governance, so there is no new build to update to. I'm fixing that right now. Unsure how the dependencies got out of sync, but I'll put up an SDK pr as soon as the newer version is available. (I've checked with a darc update-dependencies that it brings them back into sync) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/dotnet/razor-compiler/issues/318
Fixes dotnet/source-build#2946