Fix various formatting issues with lambdas in generated code#6245
Merged
davidwengier merged 3 commits intodotnet:mainfrom May 26, 2022
Merged
Conversation
|
Heart stopped until I saw the actual files changed 😆 |
|
So is the gist here that our TagHelper test files were straight up wrong? |
Member
Author
Wrong is debatable, but certainly out of date. Couldn't use |
Ahhh ok ya that makes sense and that was the TagHelper that exhibited the issue |
156162b to
9dae332
Compare
9dae332 to
e94de3e
Compare
NTaylorMullen
approved these changes
May 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6158
Fixes #5693
Fixes #6001
Fixes #5676
Test only PR, these are all fixed by the Roslyn bump, because dotnet/roslyn#60437 is fixed.