Respond to Roslyn frozen compilation changes in semantic tokens#4156
Merged
allisonchou merged 13 commits intomainfrom Aug 31, 2021
Merged
Respond to Roslyn frozen compilation changes in semantic tokens#4156allisonchou merged 13 commits intomainfrom
allisonchou merged 13 commits intomainfrom
Conversation
ryanbrandenburg
approved these changes
Aug 27, 2021
Contributor
ryanbrandenburg
left a comment
There was a problem hiding this comment.
Changes seem good, 
after the ImmutableArray question is resolved one way or another.
...ks/Microsoft.AspNetCore.Razor.Microbenchmarks/LanguageServer/RazorSemanticTokensBenchmark.cs
Outdated
Show resolved
Hide resolved
...rosoft.AspNetCore.Razor.LanguageServer/Semantic/Models/ProvideSemanticTokensEditsResponse.cs
Show resolved
Hide resolved
...rosoft.AspNetCore.Razor.LanguageServer/Semantic/Models/ProvideSemanticTokensEditsResponse.cs
Show resolved
Hide resolved
...rosoft.AspNetCore.Razor.LanguageServer/Semantic/Models/ProvideSemanticTokensEditsResponse.cs
Show resolved
Hide resolved
...t.AspNetCore.Razor.LanguageServer/Semantic/Services/DefaultRazorSemanticTokensInfoService.cs
Show resolved
Hide resolved
...Razor/src/Microsoft.VisualStudio.LanguageServerClient.Razor/VSSemanticTokensDeltaResponse.cs
Outdated
Show resolved
Hide resolved
src/Razor/src/Microsoft.VisualStudio.LanguageServerClient.Razor/VSSemanticTokensResponse.cs
Outdated
Show resolved
Hide resolved
ryanbrandenburg
approved these changes
Aug 31, 2021
Contributor
ryanbrandenburg
left a comment
There was a problem hiding this comment.
One suggestion WRT out-of-sync C# responses. Not SUPER important since that scenario should be very rare now that we try to force syncing, but worth fixing if it does mess things up too bad.
...oft.VisualStudio.LanguageServerClient.Razor/DefaultRazorLanguageServerCustomMessageTarget.cs
Outdated
Show resolved
Hide resolved
…r/DefaultRazorLanguageServerCustomMessageTarget.cs Co-authored-by: Ryan Brandenburg <rybrande@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the changes
IsPartialproperty). If partial tokens are returned, we need to keep re-queueing Roslyn for tokens until the token set is complete.