Conversation
…ode> Agent-Logs-Url: https://github.com/dotnet/razor/sessions/a3fc45dd-ff43-4532-bcec-d9f06d1db966 Co-authored-by: chsienki <16246502+chsienki@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Implement IReadOnlyList<IntermediateNode> in IntermediateNodeCollection
Make IntermediateNodeCollection implement IReadOnlyList<IntermediateNode>
Apr 3, 2026
ToddGrun
reviewed
Apr 3, 2026
| namespace Microsoft.AspNetCore.Razor.Language.Intermediate; | ||
|
|
||
| public sealed class IntermediateNodeCollection : IList<IntermediateNode> | ||
| public sealed class IntermediateNodeCollection : IList<IntermediateNode>, IReadOnlyList<IntermediateNode> |
Contributor
There was a problem hiding this comment.
Are there some places we can change to take advantage of this, or is that coming later?
Member
There was a problem hiding this comment.
Yeah there are places. It'll be a follow up just because of the way I broke up the github issues.
ToddGrun
approved these changes
Apr 3, 2026
This was referenced Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the changes
IntermediateNodeCollectionalready hadCountand an indexed getter but didn't declareIReadOnlyList<IntermediateNode>, blocking standard LINQ and list-pattern usage onChildrencollections.Added
IReadOnlyList<IntermediateNode>to the interface list — no new members needed, purely additive.Enables patterns like:
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
st8vsblobprodcus339.vsblob.vsassets.io/usr/share/dotnet/dotnet dotnet build src/Compiler/Microsoft.CodeAnalysis.Razor.Compiler/src/Microsoft.CodeAnalysis.Razor.Compiler.csproj(dns block)If you need me to access, download, or install something from one of these locations, you can either: