Rename ElementOrTagHelper IR nodes to UnresolvedElement#13002
Merged
Conversation
Agent-Logs-Url: https://github.com/dotnet/razor/sessions/92527046-c306-463a-be01-7fd473437176 Co-authored-by: chsienki <16246502+chsienki@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Rename ElementOrTagHelper IR nodes to UnresolvedElement
Rename ElementOrTagHelper IR nodes to UnresolvedElement
Apr 3, 2026
davidwengier
approved these changes
Apr 3, 2026
This was referenced Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the changes
*OrTagHelper*naming was ambiguous; the newUnresolved*names better convey that these nodes represent elements/attributes not yet resolved as tag helpers.Renames:
ElementOrTagHelperIntermediateNode→UnresolvedElementIntermediateNodeMarkupOrTagHelperAttributeIntermediateNode→UnresolvedAttributeIntermediateNodeMarkupOrTagHelperAttributeValueIntermediateNode→UnresolvedAttributeValueIntermediateNodeCSharpOrTagHelperExpressionAttributeValueIntermediateNode→UnresolvedExpressionAttributeValueIntermediateNodeFiles updated:
DefaultRazorIntermediateNodeLoweringPhase.cs(including_insideElementOrTagHelper→_insideUnresolvedElement)DefaultTagHelperResolutionPhase.csand its partial files (ComponentTagHelperResolver,LegacyTagHelperResolver)<see cref="..."/>references throughoutWarning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
st8vsblobprodcus339.vsblob.vsassets.io/usr/share/dotnet/dotnet dotnet build src/Compiler/Microsoft.CodeAnalysis.Razor.Compiler/src/Microsoft.CodeAnalysis.Razor.Compiler.csproj /home/REDACTED/work/razor/razor/src/Compiler/Microsoft.AspNetCore.Razor.Language/test/TestFiles/IntegrationTests/ComponentRuntimeCodeGenerationTest/FormName_Component_RazorLangVe--norc est/�� est/TestFiles/IntegrationTests/ComponentRuntimeCodeGenerationTest/VoidTagName_NoMatchingComponenbash est/TestFiles/IntegrationTests/ComponentRuntimeCodeGenerationTest/FormName_Component_RazorLangVe--norc Razor.Language/t/home/REDACTED/work/razor/razor/src/Razor/src/Microsoft.VisualStudio.LanguageServe--noprofile Razor.Language/tgrep Razor.Language/t-l Razor.Language/tElementOrTagHelper\|MarkupOrTagHelper\|CSharpOrTagHelperExpression Razor.Language/t/home/REDACTED/work/razor/razor/src/Compiler/Microsoft.AspNetCore.Razor.Language/test/TestFiles/IntegrationTests/ComponentRuntimePreprocessorDirectiveTest/MisplacedEndingDirective_09/TestComponent.ir.txt Razo�� er Razor.Language/t/home/REDACTED/work/razor/razor/src/Compiler/Microsoft.AspNetCore.Razor.Language/t--norc Razor.Language/t/home/REDACTED/work/razor/razor/src/Compiler/Microsoft.AspNetCore.Razor.Language/t--noprofile Razor.Language/tbash Razor.Language/t--norc Razor.Language/t--noprofile Razor.Language/t/home/REDACTED/work/razor/razor/src/Compiler/Microsoft.AspNetCore.Razor.Language/test/TestFiles/IntegrationTests/ComponentRuntimePreprocessorDirectiveTest/StartOfLine_07/TestComppush(dns block)If you need me to access, download, or install something from one of these locations, you can either: