Remove cohost feature flag and various associated non-cohosting features#12874
Merged
davidwengier merged 22 commits intodotnet:mainfrom Mar 9, 2026
Merged
Remove cohost feature flag and various associated non-cohosting features#12874davidwengier merged 22 commits intodotnet:mainfrom
davidwengier merged 22 commits intodotnet:mainfrom
Conversation
…o etc. etc. Sorry, this one is big and viral
ToddGrun
reviewed
Mar 8, 2026
| { | ||
| Context = null, | ||
| ProjectIdentifier = documentSnapshot.Project.Key.Id, | ||
| ProjectIdentifier = documentSnapshot.Project.IntermediateOutputPath, |
Contributor
Member
Author
There was a problem hiding this comment.
Yeah, this isn't even displayed anywhere AFAIK. In general, the whole concept of normalization can go away entirely now I think. Arguably so can the idea of document and project snapshots.
ToddGrun
reviewed
Mar 8, 2026
| => CheckIfFileUriAndExtensionMatch(uri, LanguageServerConstants.CSharpVirtualDocumentSuffix); | ||
|
|
||
| public bool IsVirtualCSharpFile(Uri uri) | ||
| { |
Contributor
|
As far as I can tell, things look good, but to be fair, I had no idea 80% of what was removed in this PR even existed. |
Member
Author
I knew it existed, but I'd have been hard pressed to tell you whether it was necessary :) |
This was referenced Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More fixes #12491
Still more code to delete, and clean up, but I think I might pause here for a little while :)