Don't show error bars during format on paste#12806
Merged
davidwengier merged 5 commits intodotnet:mainfrom Feb 23, 2026
Merged
Conversation
chsienki
reviewed
Feb 23, 2026
| return await _formattingService.GetDocumentFormattingChangesAsync(context, htmlChanges, linePositionSpan, options, cancellationToken).ConfigureAwait(false); | ||
| } | ||
| catch (Exception) when (options.FromPaste) | ||
| { |
Member
There was a problem hiding this comment.
Are these logged inside the formatting service at least? And if so, do we want the formatting service to know that it came from paste so we can see that in the logs?
Member
Author
There was a problem hiding this comment.
Yes, the errors messages are logged by the formatting logger, and its the logger in OOP that catches the error being logged, and throws the exception to trigger the info bar, which is what we're swallowing here. The full options object is also logged, so we'll know from now on whether the format operation is from a paste. To actually solve this issue, I had to basically guess :)
chsienki
approved these changes
Feb 23, 2026
This was referenced Feb 24, 2026
This was referenced Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12805
The paste here leaves the document with multiple syntax errors which the Razor parser doesn't do a great job with (Html document ends up with close braces, C# document ends up with div tags) which makes formatting throw up. We already have code that skips range formatting if there are Razor diagnostics, but in this case there are only C# diagnostics, and it's too expensive to query them, especially during typing.