Fix extra character insertion during attribute completion in VS Code#12177
Merged
davidwengier merged 8 commits intodotnet:mainfrom Sep 5, 2025
Merged
Fix extra character insertion during attribute completion in VS Code#12177davidwengier merged 8 commits intodotnet:mainfrom
davidwengier merged 8 commits intodotnet:mainfrom
Conversation
This is not relevant to the issue, just annoyed me today :)
DustinCampbell
approved these changes
Sep 4, 2025
...azor/src/Microsoft.CodeAnalysis.Razor.Workspaces/Remote/RemoteClientInitializationOptions.cs
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: microsoft/vscode-dotnettools#2296
Seems to fix dotnet/vscode-csharp#7678 but there might be a reason @alexgav didn't close it, so I'm leaving it open.
In #11681 Alex made it so we didn't advertise broadly applicable commit characters in VS Code, which fixed the above issues for Html attributes, but we were still adding explicit commit characters to Razor completion items. This fixes that.This is not relevant to the issue, just annoyed me today :)
First commit is irrelevant, just something I noticed filled up our logs. Fifth commit is annoyingly large, as it's a rename of a flag that was already used for two purposes, but now it's at least 99% used for commit characters, and only once used for trigger characters. Logged #12176 for a bit of a follow up there.