Fix potentially ambiguous System.Object in _Imports.razor#10999
Merged
jjonescz merged 3 commits intodotnet:mainfrom Oct 14, 2024
Merged
Fix potentially ambiguous System.Object in _Imports.razor#10999jjonescz merged 3 commits intodotnet:mainfrom
jjonescz merged 3 commits intodotnet:mainfrom
Conversation
333fred
approved these changes
Oct 11, 2024
chsienki
approved these changes
Oct 11, 2024
This was referenced Oct 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See the added test and the second commit for the behavior change (previously it would fail to compile because of
System.Objectbeing there without anyglobal::prefix). Instead ofglobal::-prefixing it, I chose to use the C#objectkeyword, because it's shorter (and also more unambiguous? I'm not sure).I plan to look for other similar bugs in the codebase and open follow up PRs if I find any.