Cohost Go To Implementation#10824
Merged
davidwengier merged 6 commits intodotnet:mainfrom Sep 6, 2024
Merged
Conversation
DustinCampbell
approved these changes
Sep 3, 2024
Member
DustinCampbell
left a comment
There was a problem hiding this comment.
The code looks solid to me. This is definitely good to go in once the Roslyn dependencies are updated and CI passes.
src/Razor/src/Microsoft.CodeAnalysis.Remote.Razor/RazorDocumentServiceBase.cs
Show resolved
Hide resolved
src/Razor/src/Microsoft.CodeAnalysis.Remote.Razor/RazorDocumentServiceBase.cs
Show resolved
Hide resolved
...soft.VisualStudio.LanguageServices.Razor.Test/Cohost/CohostGoToImplementationEndpointTest.cs
Outdated
Show resolved
Hide resolved
ryzngard
approved these changes
Sep 3, 2024
…ation # Conflicts: # eng/targets/Services.props
This should have been fixed with dotnet#10807 but without the Roslyn bump I guess I didn't realise. Oops!
This was referenced Sep 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs dotnet/roslyn#74978
Fixes #10695
Part of #9519
Pretty straightforward. A tiny bit of code moved to be shared with Go To Def, but that's it.