Skip to content

Cohosting tests for Uri presentation#10642

Merged
davidwengier merged 6 commits intodotnet:mainfrom
davidwengier:CohostUriPresentationTests
Jul 19, 2024
Merged

Cohosting tests for Uri presentation#10642
davidwengier merged 6 commits intodotnet:mainfrom
davidwengier:CohostUriPresentationTests

Conversation

@davidwengier
Copy link
Member

@davidwengier davidwengier commented Jul 18, 2024

Part of #9519 and #10603

After this, all cohost endpoints have test coverage 😁

@davidwengier davidwengier requested a review from a team as a code owner July 18, 2024 05:48
@davidwengier
Copy link
Member Author

Thought of a missing test case, added it, found a product bug! This whole testing malarky works, who knew?!

@davidwengier
Copy link
Member Author

@DustinCampbell curious if you have any thoughts about the last commit? Eventually we might need something that can be used by multiple services, to control whether their endpoints should do further processing, so we can flesh this out later, I'm mainly curious if you are staunchly against me defining a record inside an interface :)

@DustinCampbell
Copy link
Member

@DustinCampbell curious if you have any thoughts about the last commit? Eventually we might need something that can be used by multiple services, to control whether their endpoints should do further processing, so we can flesh this out later, I'm mainly curious if you are staunchly against me defining a record inside an interface :)

I'm good with the change you made. I agree that we'll need something that can be used by other services later. I have no problem with types defined inside interfaces. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants