Skip to content

Handle :get/:set in EditorRequired checking#10628

Merged
jjonescz merged 3 commits intodotnet:mainfrom
jjonescz:10553-EditorRequired-bindGetSet
Jul 17, 2024
Merged

Handle :get/:set in EditorRequired checking#10628
jjonescz merged 3 commits intodotnet:mainfrom
jjonescz:10553-EditorRequired-bindGetSet

Conversation

@jjonescz
Copy link
Copy Markdown
Member

Fixes #10553.

@jjonescz jjonescz added the area-compiler Umbrella for all compiler issues label Jul 16, 2024
@jjonescz jjonescz marked this pull request as ready for review July 16, 2024 11:54
@jjonescz jjonescz requested review from a team as code owners July 16, 2024 11:55
@Bouke
Copy link
Copy Markdown

Bouke commented Oct 17, 2024

Does this also handle first scenario reported in #10553, with @bind-Value?

@jjonescz
Copy link
Copy Markdown
Member Author

jjonescz commented Oct 17, 2024

Does this also handle first scenario reported in #10553, with @bind-Value?

@bind-Value should have been already fixed by #8337.

But I just noticed that in the bug report EditorRequired is applied also to ValueChanged property - that looks like a variant not handled by either PR. I will investigate that.

@jjonescz
Copy link
Copy Markdown
Member Author

@Bouke thanks for bringing an attention to this; I'm fixing the mentioned cases in #11043.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-compiler Umbrella for all compiler issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RZ2012: False positive for different Blazor binding syntaxes

5 participants