Merged
Conversation
6 tasks
DustinCampbell
approved these changes
Jul 15, 2024
Member
Author
|
Well I guess my previous fixes didn't change the file path normalization issue 🤦♂️ |
ryzngard
approved these changes
Jul 15, 2024
Member
Author
|
Have updated to remove a couple of statics, and run all tests with and without the Precise Semantic Tokens feature flag. Also, I think I'll wait for Dustin's PR to merge first. |
…SemanticTokensTests # Conflicts: # src/Razor/src/Microsoft.CodeAnalysis.Remote.Razor/Initialization/RemoteClientInitializationService.cs # src/Razor/src/Microsoft.CodeAnalysis.Remote.Razor/Initialization/RemoteClientInitializationServiceFactory.cs # src/Razor/test/Microsoft.VisualStudio.LanguageServices.Razor.Test/Cohost/CohostTestBase.cs
DustinCampbell
approved these changes
Jul 16, 2024
This was referenced Jul 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #9519 and #10603
This was fairly straight forward too, though adding MVC files to the mix found a bug in our test data, which is kind of humorous.
I decided not to copy all of the semantic tokens tests we have, but rather just create something reasonably all-encompassing. The core engine is shared so both sets of tests exercise it anyway.