Support folding ranges in cohosting#10447
Merged
davidwengier merged 16 commits intodotnet:mainfrom Jun 25, 2024
Merged
Conversation
I don't actually know why, but the OOPFoldingRangeService breaks out MEF composition without this.
Contributor
The most American thing we can do is import this code via plane instead of using the internet. |
Member
Author
|
Ping @dotnet/razor-tooling for reviews if you please :) |
chsienki
reviewed
Jun 17, 2024
# Conflicts: # src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/Folding/FoldingRangeEndpoint.cs # src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/RazorLanguageServer.cs
alexgav
approved these changes
Jun 20, 2024
|
|
||
| internal interface IFoldingRangeService | ||
| { | ||
| ImmutableArray<FoldingRange> GetFoldingRanges(RazorCodeDocument codeDocument, ImmutableArray<FoldingRange> csharpRanges, ImmutableArray<FoldingRange> htmlRanges, CancellationToken cancellationToken); |
Contributor
There was a problem hiding this comment.
Super-nit: seems like an excessively long line :) (now that I"m used to VSCode yelling at me for that...)
Member
Author
There was a problem hiding this comment.
I have a 34" widescreen monitor 😛
|
|
||
| internal interface IRemoteFoldingRangeService | ||
| { | ||
| ValueTask<ImmutableArray<RemoteFoldingRange>> GetFoldingRangesAsync(RazorPinnedSolutionInfoWrapper solutionInfo, DocumentId documentId, ImmutableArray<RemoteFoldingRange> htmlRanges, CancellationToken cancellationToken); |
Contributor
There was a problem hiding this comment.
same super-nit about long line
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #9519
This was all written a while ago, but was waiting for a Roslyn VS insertion before it could be merged. That has now happened, so all of this productive code writen on pure Australian soil can be reviewed.