UriPresentation to Cohost/OOP, Part 1#10336
Merged
davidwengier merged 5 commits intodotnet:mainfrom May 2, 2024
Merged
Conversation
01eac68 to
aff7004
Compare
aff7004 to
ab4c134
Compare
alexgav
reviewed
May 2, 2024
...azor/src/Microsoft.CodeAnalysis.Remote.Razor/UriPresentation/RemoteUriPresentationService.cs
Show resolved
Hide resolved
alexgav
reviewed
May 2, 2024
...or/src/Microsoft.CodeAnalysis.Razor.Workspaces/DocumentPresentation/UriPresentationHelper.cs
Outdated
Show resolved
Hide resolved
alexgav
reviewed
May 2, 2024
...azor/src/Microsoft.CodeAnalysis.Remote.Razor/UriPresentation/RemoteUriPresentationService.cs
Outdated
Show resolved
Hide resolved
alexgav
reviewed
May 2, 2024
...azor/src/Microsoft.CodeAnalysis.Remote.Razor/UriPresentation/RemoteUriPresentationService.cs
Show resolved
Hide resolved
alexgav
reviewed
May 2, 2024
...c/Microsoft.CodeAnalysis.Remote.Razor/UriPresentation/RemoteUriPresentationServiceFactory.cs
Show resolved
Hide resolved
alexgav
reviewed
May 2, 2024
...t.VisualStudio.LanguageServices.Razor/LanguageClient/Cohost/CohostUriPresentationEndpoint.cs
Show resolved
Hide resolved
DustinCampbell
approved these changes
May 2, 2024
...azor/src/Microsoft.CodeAnalysis.Remote.Razor/UriPresentation/RemoteUriPresentationService.cs
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #9519
This enables the Uri Presentation endpoint in cohosting, which is used when draging and dropping a file only a Razor document, and handles placing a Razor component tag in the document. It's part 1 because part 2 involves calling out to Web Tools to allow the Html language server to do the same, but I haven't done that bit yet. No point reviewing it all in one huge lump though.
This is also a reasonable "bare minimum" changes necessary to create a new cohost endpoint and service.