Lower drop retention from 10 years to 3 months#10288
Merged
jjonescz merged 1 commit intodotnet:mainfrom Apr 23, 2024
Merged
Conversation
jaredpar
approved these changes
Apr 22, 2024
This was referenced Apr 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a warning in official builds:
##[warning]DropRetentionDays not set. Defaulting to 10 years (3650 days). Please reduce drop retention period to 30 days if possible.I'm not sure what value to replace 10 years with - the drop is inserted into VS (and if it ends up in VS release branch I presume it's still used for releasing) so probably shouldn't live too shortly. I chose 90 days as that's the example in https://eng.ms/docs/cloud-ai-platform/devdiv/one-engineering-system-1es/1es-docs/1es-pipeline-templates/features/outputs/microbuild-vsts-drop?tabs=inlinetask.
Official build run: https://dev.azure.com/dnceng/internal/_build/results?buildId=2435732&view=results