-
Notifications
You must be signed in to change notification settings - Fork 238
Comparing changes
Open a pull request
base repository: dotnet/razor
base: 64910d5bea
head repository: dotnet/razor
compare: 16ec5eb521
- 12 commits
- 36 files changed
- 1 contributor
Commits on Jan 22, 2025
-
Provide debugger strings on default imports
This provides better debugger strings for the RazorProjectItems that represent default imports.
Configuration menu - View commit details
-
Copy full SHA for 73b08f6 - Browse repository at this point
Copy the full SHA 73b08f6View commit details -
Seal all IImportProjectFeature implementations
Some were sealed, some weren't.
Configuration menu - View commit details
-
Copy full SHA for ce64430 - Browse repository at this point
Copy the full SHA ce64430View commit details -
IImportProjectFeature: Change accessibility to internal
This change makes the IImportProjectFeature interface internal. In addition, the SetImportFeature extension method on RazorProjectEngineBuilder has been moved to the common test library, since it's really intended to be used by tests. This is a public API breaking change, but there are no users of these APIs in dotnet/sdk.
Configuration menu - View commit details
-
Copy full SHA for 309862d - Browse repository at this point
Copy the full SHA 309862dView commit details -
Share TestImportProjectFeature across compiler and tooling tests
Consolidate the three "TestImportProjectFeature" classes and place it in Microsoft.AspNetCore.Razor.Test.Common.
Configuration menu - View commit details
-
Copy full SHA for b937a47 - Browse repository at this point
Copy the full SHA b937a47View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8ec6ad5 - Browse repository at this point
Copy the full SHA 8ec6ad5View commit details -
Configuration menu - View commit details
-
Copy full SHA for ef010b8 - Browse repository at this point
Copy the full SHA ef010b8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9be372f - Browse repository at this point
Copy the full SHA 9be372fView commit details -
Consolidate RazorProjectItems for default imports
This change introduces a DefaultImportProjectItem that is shared across features that add default imports.
Configuration menu - View commit details
-
Copy full SHA for fecec1d - Browse repository at this point
Copy the full SHA fecec1dView commit details
Commits on Jan 23, 2025
-
PooledArrayBuilder: Add ToImmutableReversed and DrainToImmutableReversed
Add a couple of methods to PooledArrayBuilder to produce a reversed ImmutableArray.
Configuration menu - View commit details
-
Copy full SHA for b502495 - Browse repository at this point
Copy the full SHA b502495View commit details -
RazorProjectFileSystem: Improve performance of FindHierarchicalItems
This change rewrites RazorProjectFileSystem.FindHierarchicalItems(...) to avoid allocations. It now returns results in reverse order, since every caller in Razor immediately called `Reverse()`. In addition, the access has been reduced to internal since there are no external callers of this method.
Configuration menu - View commit details
-
Copy full SHA for 14e2159 - Browse repository at this point
Copy the full SHA 14e2159View commit details
Commits on Jan 24, 2025
-
Remove depth check from RazorProjectFileSystem.FindHierarchicalItems
FindHierarchicalItem has a "max depth" check to ensure that it returns a maximum of 255 file paths. However, all this method does is perform string manipulation by looking for '/' characters. It does not actually touch the file system. Technically, this could result in a breaking change because this method is used to find applicable Imports files. So, if the user had a Razor project with 256+ nested subdirectories, the compiler would now consider Imports that it might not have considered in the past. However, that seems like a highly unlikely situation and it's even more unlikely that a user would depend on that behavior.
Configuration menu - View commit details
-
Copy full SHA for 872b397 - Browse repository at this point
Copy the full SHA 872b397View commit details
Commits on Jan 30, 2025
-
Clean up and rationalize imports in the compiler (#11409)
This change represents a lot of clean up and consolidate a lot of code around how imports are provided and queried for in the compiler. There are a couple of API breaking changes here that shouldn't have external impact. In particular, I've made `IImportProjectFeature` internal and changed its API significantly. In addition, I've rewritten `RazorProjectFileSystem.FindHierarchicalItems(...)` to reduce allocations, make it more efficient, and return its results in reversed order (since every caller immediately called `Reverse()`). CI Build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2626377&view=results Test Insertion: https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/605137
Configuration menu - View commit details
-
Copy full SHA for 16ec5eb - Browse repository at this point
Copy the full SHA 16ec5ebView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 64910d5bea...16ec5eb521