Skip to content

Build DotNetDeltaApplier and BrowserRefresh dependencies using source packages#9822

Merged
LittleLittleCloud merged 8 commits intodotnet:mainfrom
tmat:TraceLoggingMain
Dec 12, 2025
Merged

Build DotNetDeltaApplier and BrowserRefresh dependencies using source packages#9822
LittleLittleCloud merged 8 commits intodotnet:mainfrom
tmat:TraceLoggingMain

Conversation

@tmat
Copy link
Member

@tmat tmat commented Oct 10, 2025 •
edited
Loading

Build Microsoft.Extensions.DotNetDeltaApplier and Microsoft.AspNetCore.Watch.BrowserRefresh binaries from this repository, instead of referencing binary packages built by dotnet/sdk.

Suppresses conversion of Portable PDBs to Windows PDBs for above components. These binaries are not loaded to VS processes, so VS insertion symchk can be suppressed by adding entry to
https://devdiv.visualstudio.com/DevDiv/_git/VS?path=/src/ProductData/Engineering/SymbolArchiveWhiteList.csv

@tmat tmat requested a review from a team as a code owner October 10, 2025 16:13
@tmat tmat changed the title Trace logging main Disable Trace level log messages Oct 10, 2025
@LittleLittleCloud LittleLittleCloud enabled auto-merge (squash) October 10, 2025 16:15
@tmat tmat mentioned this pull request Oct 10, 2025
Merged
@drewnoakes
Copy link
Member

drewnoakes commented Oct 12, 2025

Compile error in release for net472:

C:\Users\cloudtest.nuget\packages\microsoft.dotnet.hotreload.client\10.0.100-rtm.25508.107\contentFiles\cs\net472\DefaultHotReloadClient.cs(110,9): error CS8774: Member '_pipe' must have a non-null value when exiting.

Seems like the content file of the upstream source needs to suppress nullability, or enable it and fix this issue.

@tmat
Copy link
Member Author

tmat commented Oct 13, 2025 •
edited
Loading

Needs dotnet/sdk#51193, dotnet/dotnet#2873

@tmat tmat force-pushed the TraceLoggingMain branch from 5a5a705 to ea2d93a Compare October 17, 2025 17:11
@tmat tmat marked this pull request as draft October 17, 2025 17:13
auto-merge was automatically disabled October 17, 2025 17:13

Pull request was converted to draft

@tmat tmat changed the title Disable Trace level log messages Update to the latest Hot Reload packages Oct 17, 2025
@tmat tmat mentioned this pull request Oct 17, 2025
Merged
@tmat tmat force-pushed the TraceLoggingMain branch from 1d9e217 to 5c3e55c Compare October 17, 2025 20:13
@tmat tmat mentioned this pull request Oct 19, 2025
Closed
@tmat tmat force-pushed the TraceLoggingMain branch from 5c3e55c to 2835692 Compare November 4, 2025 17:23
@tmat tmat changed the title Update to the latest Hot Reload packages Build DotNetDeltaApplier and BrowserRefresh from the repo Nov 4, 2025
@tmat tmat changed the title Build DotNetDeltaApplier and BrowserRefresh from the repo Build DotNetDeltaApplier and BrowserRefresh using source packages Nov 4, 2025
@tmat tmat changed the title Build DotNetDeltaApplier and BrowserRefresh using source packages Build DotNetDeltaApplier and BrowserRefresh dependencies using source packages Nov 4, 2025
@tmat tmat force-pushed the TraceLoggingMain branch from 7bcc21a to 5134914 Compare November 4, 2025 19:24
@tmat tmat marked this pull request as ready for review November 5, 2025 00:00
@LittleLittleCloud LittleLittleCloud self-requested a review November 5, 2025 17:14
LittleLittleCloud
LittleLittleCloud reviewed Nov 5, 2025
View reviewed changes
@tmat
Copy link
Member Author

tmat commented Nov 21, 2025

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Nov 21, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@tmat
Copy link
Member Author

tmat commented Nov 21, 2025

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Nov 21, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@LittleLittleCloud
Copy link
Member

LittleLittleCloud commented Dec 3, 2025

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Dec 3, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@tmat tmat mentioned this pull request Dec 12, 2025
Merged
3 tasks
@tmat
Copy link
Member Author

tmat commented Dec 12, 2025

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Dec 12, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@tmat
Copy link
Member Author

tmat commented Dec 12, 2025

Filed https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2663089 to get teh package restore issue resolved.

@tmat
Copy link
Member Author

tmat commented Dec 12, 2025

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Dec 12, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@tmat
Copy link
Member Author

tmat commented Dec 12, 2025

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Dec 12, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@LittleLittleCloud LittleLittleCloud merged commit 72a7fd1 into dotnet:main Dec 12, 2025
5 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 18.3 milestone Dec 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LittleLittleCloud LittleLittleCloud LittleLittleCloud approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

18.3

Development

Successfully merging this pull request may close these issues.

3 participants

@tmat @drewnoakes @LittleLittleCloud