Added a few benchmarks for casting performance. Primarily dealing with variance.#922
Merged
billwert merged 6 commits intodotnet:masterfrom Oct 10, 2019
Merged
Added a few benchmarks for casting performance. Primarily dealing with variance.#922billwert merged 6 commits intodotnet:masterfrom
billwert merged 6 commits intodotnet:masterfrom
Conversation
Member
Author
|
CC: @jkotas , @davidwrighton , @sergiy-k |
jkotas
reviewed
Oct 8, 2019
…f casts in benchmark loops.
gfoidl
reviewed
Oct 9, 2019
billwert
suggested changes
Oct 9, 2019
Member
Author
|
I think I have addressed all the concerns so far. |
billwert
approved these changes
Oct 10, 2019
Contributor
billwert
left a comment
There was a problem hiding this comment.
One comment of another minor cleanup we could do. I think it's fine as it stands but the fix wouldn't hurt either.
I'll merge this sometime tomorrow morning to give others time to review and you to make this change if you want.
Member
Author
|
Also - it looks like I do not have write access to this. |
adamsitnik
reviewed
Oct 14, 2019
| [Benchmark] | ||
| public void AssignArrayElementByVariance() | ||
| { | ||
| // no return is needed. The cast is potentially throwing and thus is not optimizable. |
Member
There was a problem hiding this comment.
thanks for adding the comment! 👍
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like there is a good number of casting benchmarks already.
Just adding a few to cover variance and array conversions.