[iOS] Simplify iOS performance measurement scripts#5007
Merged
matouskozak merged 1 commit intodotnet:mainfrom Oct 13, 2025
Merged
[iOS] Simplify iOS performance measurement scripts#5007matouskozak merged 1 commit intodotnet:mainfrom
matouskozak merged 1 commit intodotnet:mainfrom
Conversation
- clearer naming of codegen/runtime variants - remove non strip symbols variants
kotlarmilos
approved these changes
Oct 8, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies iOS performance measurement scripts by refactoring naming conventions to be more consistent and removing measurements where symbol stripping is disabled (StripSymbol=false scenarios).
- Standardized artifact naming to include runtime type, code generation method, and symbol stripping status
- Removed all performance measurement scenarios that keep symbols (StripSymbols=false)
- Changed default iOSStripSymbols parameter from false to true
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| eng/pipelines/upload-build-artifacts-jobs.yml | Updated artifact names to include runtime type prefixes and removed symbol-keeping variants |
| eng/pipelines/templates/runtime-perf-job.yml | Simplified conditional logic by removing StripSymbols=false scenarios and updated artifact names |
| eng/pipelines/templates/run-performance-job.yml | Changed default iOSStripSymbols parameter from false to true |
| eng/pipelines/runtime-ios-scenarios-perf-jobs.yml | Removed duplicate job configurations for StripSymbols=false scenarios and updated remaining jobs |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
LoopedBard3
approved these changes
Oct 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated dotnet/runtime PR: dotnet/runtime#120531
Test run: https://dev.azure.com/dnceng/internal/_build/results?buildId=2810833