Add a general multi-dimensional array benchmark #2093
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is similar to MDArray2, but uses the GetLowerBound/GetUpperBound APIs. The iteration count is lowered compared to MDArray2 because using these APIs slows the benchmark considerably.
Contributor
Author
|
The test failures are not in the microbenchmarks. |
Contributor
Author
|
@DrewScoggins PTAL |
Contributor
Author
|
@DrewScoggins @adamsitnik @DrewScoggins Who should review and merge runtime micro-benchmark additions/changes? E.g., the JIT team doesn't have commit permission to this repo. |
Member
|
Sorry, I was looking at this a couple days ago and got distracted, and never got back around to this. The change LGTM, I will just merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is similar to MDArray2, but uses the GetLowerBound/GetUpperBound
APIs.
The iteration count is lowered compared to MDArray2 because using these
APIs slows the benchmark considerably.