Refactor System.Collections/Sort and add Span test cases#1400
Closed
nietras wants to merge 9 commits intodotnet:mainfrom
Closed
Refactor System.Collections/Sort and add Span test cases#1400nietras wants to merge 9 commits intodotnet:mainfrom
nietras wants to merge 9 commits intodotnet:mainfrom
Conversation
jkotas
reviewed
Jul 20, 2020
Member
|
@nietras do you want to continue with this PR? someone from @dotnet/area-system-collections can review it. |
eiriktsarpalis
requested changes
Feb 7, 2022
Member
eiriktsarpalis
left a comment
There was a problem hiding this comment.
We generally don't want to change existing benchmark suites as that tends to mess our performance reporting history cc @adamsitnik
Also, Span benchmarks arguably belong in the System.Memory suites and not System.Collections. Have you checked if they define tests for sorting?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of the dotnet/runtime#39543 we need this to fully cover and detail sorting code paths and scenarios. Includes floating point benchmarks for completeness. cc: @jkotas @stephentoub
This also replaces the same invocations per iteration count for all scenarios with a per test case scenario that meant some of the benchmarks were unreliable or took "too long".
It doesn't appear
NETCOREAPP5_0is defined, how can we specify this so Span tests only included for that?TODO: