Fix issue with SHA256 instantiation#9429
Merged
YuliiaKovalova merged 7 commits intodotnet:mainfrom Nov 28, 2023
Merged
Conversation
rainersigwald
approved these changes
Nov 16, 2023
Member
rainersigwald
left a comment
There was a problem hiding this comment.
LGTM.
@sujitnayak if you have a minute could you take a look at this change to mansign2?
sujitnayak
reviewed
Nov 17, 2023
sujitnayak
reviewed
Nov 21, 2023
sujitnayak
approved these changes
Nov 21, 2023
rainersigwald
approved these changes
Nov 27, 2023
Member
rainersigwald
left a comment
There was a problem hiding this comment.
"I tried that and it doesn't work" is a pretty good reason to keep it as you had it :) Looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9248
Context
After the change from SHA256Managed -> SHA256 the instantiation was broken. SHA256 is an abstract class.
Changes Made
Get back to SHA256Managed usage
Testing
Manual + UT for guarding the changes in signing.
Before:
After:
