Removing dead code unit tests and BinFmt enablement#9126
Merged
JanKrivanek merged 3 commits intodotnet:mainfrom Aug 21, 2023
Merged
Removing dead code unit tests and BinFmt enablement#9126JanKrivanek merged 3 commits intodotnet:mainfrom
JanKrivanek merged 3 commits intodotnet:mainfrom
Conversation
Member
Author
|
@rokonec - can you have a look on fail of I thought this should have been caught - correct? |
Member
Author
Discussed offline - this is actually a wrong test (as it explicitly opts out from the checking functionality but do not assert on the BinFmt exception) |
YuliiaKovalova
approved these changes
Aug 15, 2023
rokonec
approved these changes
Aug 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8925
Context
Following types serialization is no more facilitated by BinFmt - so removing associated unit tests:
InvalidProjectFileException- allBuildExceptionBaseexceptions tested viaTestSerializationOfBuildExceptions; plusInvalidProjectFileExceptionhas it's own test:TestInvalidProjectFileException_NestedWithStackLoggerException- same as aboveProjectStartedEventArgs- serialized via translatable onlyAssemblyName_Ex- serialized via translatable only. The edited test file already contained tests for both types of serializationCopyOnWriteDictionary- not custom serialized on any codepath (possibly only viaTranslateDictionarytakingIDictionary)Changes Made
Appart from removing serialization tests of above mentioned types - removed the
EnableUnsafeBinaryFormatterSerializationwhich was needed just because of those tests