Terminal logger enablement by /tlp:default and related telemetry#9119
Merged
rokonec merged 10 commits intodotnet:mainfrom Aug 16, 2023
Merged
Terminal logger enablement by /tlp:default and related telemetry#9119rokonec merged 10 commits intodotnet:mainfrom
rokonec merged 10 commits intodotnet:mainfrom
Conversation
donJoseLuis
approved these changes
Aug 10, 2023
JanKrivanek
requested changes
Aug 11, 2023
Member
JanKrivanek
left a comment
There was a problem hiding this comment.
Overall looks good.
I have couple annoying comments that you can aknowledge and skip. The SetConsoleMode needs to be addressed though - that would cause regressions
Ensure Ansi Color Codes are enabled even for /tl:true
JanKrivanek
approved these changes
Aug 14, 2023
Member
JanKrivanek
left a comment
There was a problem hiding this comment.
I like the final version. Looks good to go to me!
6 tasks
rainersigwald
approved these changes
Aug 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes part of #9063
Context
See #9063 for requirements.
This PR address changes in msbuild only. SDK changes will be in different PR. This PRs are independent and could be merged in any order.
Changes Made
LoggingConfigurationTelemetrycontaining info about logger settingsTesting
Notes