Add unit test for https://github.com/dotnet/msbuild/pull/8870#8961
Merged
Add unit test for https://github.com/dotnet/msbuild/pull/8870#8961
Conversation
JanKrivanek
requested changes
Jun 29, 2023
Member
JanKrivanek
left a comment
There was a problem hiding this comment.
Looks as a good starting point.
I believe we need to add custom IDictionary implementation and verification of the resulting task output in order to test the fix
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rainersigwald
approved these changes
Jul 26, 2023
Member
rainersigwald
left a comment
There was a problem hiding this comment.
LGTM and I believe addresses @JanKrivanek's concerns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes 8939
Context
#8870 (comment)
Changes Made
Add a task that returns a custom ITaskItem implementation that has a custom IDictionary type returned from CloneCustomMetadata()
Add unit test TestTaskDictionaryOutputItems()