Misc fixes for /question build#8881
Conversation
yuehuang010
commented
Jun 14, 2023
- Fix an merge error in GenerateResource.NothingOutOfDate
- Avoid the complex state in WriteLines when Lines are empty. /question just always returns true. Add a test.
- Add Tracker to bootstrap, makes dogfooding C++ easier.
- Add SkipUnchangedFiles to avoid extra copy.
* Add Question switch to stop the build when targets are not incremental. * Add question property to tasks. * Add tests * Clean up IIncrementalTask interface. * Add additional tasks. * Test and Question on this repro. * fix build * Fix question in -m. Fix BindingRedirect to target incremental. * Fix tests for Linux. * WIP * Fix feedbacks * . * Revert condition. * fix feedback. * touch to rerun. * Fix merge. * Fix merge pt2 * Fix merge p3 * Fix fileState when it couldn't resolve some files. * Fix merge * Address feedbacks * Fix test. * Clean up. * WIP * Fix Feedback * Fix Feedback. * Update tests * Address some feedbacks. * Fix merge conflict * .
|
@yuehuang010 - would it be possible to split into separate PRs? I know it's small changes, but it's easier to review single intent.
|
Ah, the message changed. I might need to add another message. The goal is to Log.Error then fail fast the task. Hopefully the Error can provide an starting point for investigation.
This parameter will avoid copying the file if it determines if the source and destination are the same. It will avoid an unnecessary disk write. |
JanKrivanek
left a comment
There was a problem hiding this comment.
The GenerateResource incrementality fail message should be more informative.
Other changes looks good to go to me!
|
@yuehuang010 - your changes looks good and helpful! Do you want to spin off the GenerateResource incrementality into separate PR so that we can get this through signoff? (or improving it as part of this PR works great as well - if you'd agree with that). |
|
Oh snap, I forgot about this PR. Lets quickly spin off GenRes. |