Use EntryPointNodes in lieu of GraphRoots in GetTargetLists (#8…#8101
Merged
rokonec merged 2 commits intodotnet:mainfrom Nov 4, 2022
Merged
Use EntryPointNodes in lieu of GraphRoots in GetTargetLists (#8…#8101rokonec merged 2 commits intodotnet:mainfrom
EntryPointNodes in lieu of GraphRoots in GetTargetLists (#8…#8101rokonec merged 2 commits intodotnet:mainfrom
Conversation
Contributor
|
cc: @dfederm |
dfederm
approved these changes
Oct 28, 2022
Member
|
I think my questions then were here (#4218 (comment)), with replies. Basically, in a non-graph build of But if you have a solution that points to both, the outer build will run. Passing two projects as entry points in a graph is analogous to that, I think. So I think the commit you linked switching from EntryPointNodes to GraphRoots is incorrect. |
rainersigwald
approved these changes
Nov 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8056
Context
GraphRootswon't contain referenced projects (even if they're entry points), so useEntryPointNodeswhen obtaining the entry point nodes inGetTargetLists. This will result inBuildbeing added to the referenced project's target list, which will in the case of #8056 result inPackbeing called.Changes Made
GetTargetListsnow usesEntryPointNodesin lieu ofGraphRootsin obtaining the entry point nodes.Testing
Verified that a referenced entry project has the default target in its target list.
Notes
EntryPointNodeswas initially used (see a1ac094) but was later changed toGraphRootshere.@rainersigwald Do you have any insight as to why this change was made? You made this comment about non-graph-root outer build -- it seems relevant to the change made, so I was wondering if you could elaborate on it.