Configure OptProf v2 pipeline#8085
Conversation
rainersigwald
left a comment
There was a problem hiding this comment.
Do we have perf DDRITs on a build that consumed the output of one of these collections yet? Doesn't have to block this but will be a nice end-to-end.
| <RunSettings> | ||
| <RunConfiguration> | ||
| <ResultsDirectory>C:\Test\Results</ResultsDirectory> | ||
| <TargetPlatform>X86</TargetPlatform> |
There was a problem hiding this comment.
Is this some legacy "says X86 but doesn't really mean that" type thing?
There was a problem hiding this comment.
I think it is some legacy. We currently use this default template from dotnet/arcade. So, this line came from there. Maybe it makes sense to ask them about it.
| ref: refs/heads/main | ||
|
|
||
| stages: | ||
| - template: \templates\stages\visual-studio\single-runsettings.yml@DartLabOptProfTemplates |
There was a problem hiding this comment.
Where does this file physically live? It's not in our repo, right?
There was a problem hiding this comment.
Few lines above the git azure repo DartLabOptProfTemplates is defined. It lives there.
| $bootstrapperInfoJson = Get-Content -Raw -Path '$(Pipeline.Workspace)\ComponentBuildUnderTest\MicroBuildOutputs\BootstrapperInfo.json' | ConvertFrom-Json | ||
| $vsBranch = $bootstrapperInfoJson[0].VSBranch | ||
| Write-Host "VSBootstrapperBranch: $vsBranch" | ||
| Set-AzurePipelinesVariable 'VSBootstrapperBranch' $vsBranch |
There was a problem hiding this comment.
Question, not at all a blocker for this PR: should we tie the branch to our branchname rather than the checked-into-our-repo VS branch reference? That might reduce effort when finalizing a release, since we often forget to update that checked-in branch name.
There was a problem hiding this comment.
I took this part of code from the previous pipeline, so it is how it currently works. But we could think about improving this later.
| <Components All="false"> | ||
| <Include ID="Microsoft.VisualStudio.Component.VC.CLI.Support" /> | ||
| <Include ID="Microsoft.VisualStudio.Component.Windows81SDK" /> | ||
| <Include ID="Microsoft.VisualStudio.ComponentGroup.UWP.VC" /> | ||
| <Include ID="Microsoft.VisualStudio.Component.VC.ATLMFC" /> | ||
| <Include ID="Microsoft.VisualStudio.Component.Windows10SDK.15063.Desktop" /> | ||
| <Include ID="Microsoft.VisualStudio.Component.Windows10SDK.16299" /> | ||
| <Include ID="Microsoft.VisualStudio.Component.Windows10SDK.16299.UWP" /> | ||
| <Include ID="Microsoft.Net.ComponentGroup.4.7.2.DeveloperTools" /> | ||
| <Exclude ID="Component.Incredibuild" /> | ||
| <Exclude ID="Component.JavaJDK" /> | ||
| <Exclude ID="Microsoft.VisualStudio.Component.AspNet45" /> | ||
| </Components> | ||
| <Workloads All="false" IncludeComponents="Required,Recommended"> | ||
| <Include ID="Microsoft.VisualStudio.Workload.CoreEditor" IncludeComponents="Required" /> | ||
| <Include ID="Microsoft.VisualStudio.Workload.ManagedDesktop" IncludeComponents="Required" /> | ||
| <Include ID="Microsoft.VisualStudio.Workload.NativeCrossPlat" IncludeComponents="Required" /> | ||
| <Include ID="Microsoft.VisualStudio.Workload.NativeDesktop" IncludeComponents="Required" /> | ||
| <Include ID="Microsoft.VisualStudio.Workload.NetWeb" IncludeComponents="Required" /> | ||
| <Include ID="Microsoft.VisualStudio.Workload.Office" IncludeComponents="Required" /> | ||
| <Include ID="Microsoft.VisualStudio.Workload.Universal" IncludeComponents="Required" /> | ||
| <Include ID="Microsoft.VisualStudio.Workload.VisualStudioExtension" IncludeComponents="Required" /> | ||
| <Include ID="Microsoft.VisualStudio.Workload.Webcrossplat" IncludeComponents="Required" /> | ||
| </Workloads> |
There was a problem hiding this comment.
Are these specific to us? How were they derived?
rokonec
left a comment
There was a problem hiding this comment.
Please try to update test runs runtime to x64 4.7.2. If it does not work keep current settings and create issue to investigate why it was failing.
Yes, we do have end-to-end with VS insertion. All works. |
It is failing. Let's merge as is and I will create an issue to dig into the reason. |
Context
Configure the new pipeline for optimization data collection.
Changes Made
.ymlfile for the OptProf v2 pipeline..runsettingsfile was updated by using the custom template in the run settings generation task (instead using the default one). The default template used by the task is located here. I took it and updated with theVisualStudioConfigurationelement. This element derived from valueVSINSTALLATIONTYPE = optproffrom the legacy OptProf pipeline.Testing