Restore console mode after server build#8016
Merged
Forgind merged 4 commits intodotnet:mainfrom Sep 30, 2022
Merged
Conversation
rainersigwald
approved these changes
Sep 30, 2022
rokonec
reviewed
Sep 30, 2022
rokonec
approved these changes
Sep 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8008
Context
With MSBuild server, we adjust the console mode to be able to handle VT100 codes. We should undo that after each build to make it obvious to users mistakenly emitting VT100 codes that they should add code to properly handle them.
Customer Impact
Console settings we enable while building with MSBuild server persist after the build. In particular, if a customer is outputting raw VT100 codes, they will be properly formatted if their code is run using
dotnet run, but their customers will see the raw codes because they will not inherit anything from MSBuild.Testing
Verified that building the project from #8008 no longer had unexpected spacing when these private bits were deployed to an SDK.
Verified that the bug motivating our original support for VT100 codes is still resolved.
Unit tests.
Code Reviewers
rainersigwald, rokonec
Description of the fix
Reset VT100 codes after each build.