Undeclared projects needs to be normalized and case insensitive so that the current project can be ignored properly#7999
Merged
Forgind merged 2 commits intodotnet:mainfrom Oct 7, 2022
Conversation
…at the current project can be ignored properly
Forgind
reviewed
Sep 22, 2022
Contributor
Forgind
left a comment
There was a problem hiding this comment.
I'm not sure about OrdinalIgnoreCase here. People can (and sometimes do) have two projects identical but for casing, and this would break that scenario. Can you provide a compelling example for which we need OrdinalIgnoreCase here?
Contributor
|
@erickulcyk, did you see rainersigwald's comment? |
|
|
|
|
Forgind
approved these changes
Oct 6, 2022
Contributor
Author
|
@Forgind Do I need to be added to authorized users to be able to merge? |
rainersigwald
approved these changes
Oct 6, 2022
Contributor
|
Merged! Thanks @erickulcyk! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.