Skip to content

[main] Update dependencies from dotnet/roslyn#7835

Merged
rokonec merged 6 commits intomainfrom
darc-main-d3757b85-4712-4252-a789-4d64ca898073
Aug 11, 2022
Merged

[main] Update dependencies from dotnet/roslyn#7835
rokonec merged 6 commits intomainfrom
darc-main-d3757b85-4712-4252-a789-4d64ca898073

Conversation

@dotnet-maestro
Copy link
Copy Markdown
Contributor

@dotnet-maestro dotnet-maestro bot commented Jul 18, 2022

This pull request updates the following dependencies

From https://github.com/dotnet/roslyn

  • Subscription: 848bf81b-14ec-482f-6736-08da008bd46a
  • Build: 20220804.1
  • Date Produced: August 4, 2022 9:28:21 AM UTC
  • Commit: 83ae84b2a99a0bb1cb83525db21d467b99fd0159
  • Branch: refs/heads/release/dev17.4-vs-deps

dotnet-maestro bot and others added 5 commits July 18, 2022 12:33
…717.2

Microsoft.Net.Compilers.Toolset
 From Version 4.3.0-3.22329.30 -> To Version 4.4.0-1.22367.2
…722.14

Microsoft.Net.Compilers.Toolset
 From Version 4.3.0-3.22329.30 -> To Version 4.4.0-1.22372.14
…729.5

Microsoft.Net.Compilers.Toolset
 From Version 4.3.0-3.22329.30 -> To Version 4.4.0-2.22379.5
@Forgind
Copy link
Copy Markdown
Contributor

Forgind commented Aug 2, 2022

Should get a review from someone else before merging, since I made the last change.

@rainersigwald
Copy link
Copy Markdown
Member

Can you explain why you made that change? It looks like the PR was green.

@Forgind
Copy link
Copy Markdown
Contributor

Forgind commented Aug 3, 2022

It wasn't. That check is lying.

@Forgind
Copy link
Copy Markdown
Contributor

Forgind commented Aug 3, 2022

From jaredpar:
This is the first time MSBuild has used a compiler that has the new mtehod group to delegate caching feature. That changed the behavior of this line:

SendDataDelegate transportDelegate = PacketProcessor;

Prior to this version this was always a delegate allocation, now though it's a cached delegate conversion.
That means the transportDelegate is cached here and likely keeping what you expected to be collected in memory

@rainersigwald
Copy link
Copy Markdown
Member

Great info to put in the commit message . . .

@Forgind
Copy link
Copy Markdown
Contributor

Forgind commented Aug 3, 2022

I'm assuming it will be squashed anyway, so my commit message would disappear. You're right that it'll be good to include in the squash message.

@rainersigwald
Copy link
Copy Markdown
Member

I would not recommend squashing this, since it required an update to our code.

…804.1

Microsoft.Net.Compilers.Toolset
 From Version 4.3.0-3.22329.30 -> To Version 4.4.0-1.22404.1
@rokonec
Copy link
Copy Markdown
Member

rokonec commented Aug 8, 2022

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@rokonec rokonec added the merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now. label Aug 9, 2022
@rokonec rokonec merged commit f610bae into main Aug 11, 2022
@rokonec rokonec deleted the darc-main-d3757b85-4712-4252-a789-4d64ca898073 branch August 11, 2022 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants