Removed now obsolete featureflag regarding envvars in ToolTask#7631
Merged
rokonec merged 1 commit intoMay 27, 2022
Merged
Conversation
Since `ProcessStartInfo.Environment` is now available in all supported TFMs, the feature flag is now just obsolete and even more so an unnecessary difference between core and framework versions of msbuild.
Forgind
approved these changes
May 17, 2022
Forgind
left a comment
Contributor
There was a problem hiding this comment.
Sounds good to me, thanks!
rainersigwald
approved these changes
May 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
ProcessStartInfo.Environmentis now available in all supported TFMs,the feature flag is now just obsolete and even more so an unnecessary
difference between core and framework versions of MSBuild.
Context
Found this old feature flag to be obsolete while researching
ToolTaskbehavior.This was added during the original OSS porting work of MSBuild, when
ProcessStartInfo.Environmentwas only availablein .NET Core.
Changes Made
Use
ProcessStartInfo.Environmentfor all flavors of MSBuild.Testing
I don't think any additional testing code is needed - preexisting test suites cover this all pretty well and the change between
EnvironmentandEnvironmentVariableis only a change in type not an underlying change in behavior.Notes
trim_trailing_whitespace. I didn't remove these since that's supposed to happen at some point anyways. I hope that's ok.