CA1200: Avoid using cref tags with a prefix#7194
Merged
rokonec merged 16 commits intodotnet:mainfrom Mar 2, 2022
Merged
Conversation
elachlan
commented
Jan 2, 2022
sharwell
reviewed
Jan 3, 2022
Co-authored-by: Sam Harwell <sam@tunnelvisionlabs.com>
Co-authored-by: Sam Harwell <sam@tunnelvisionlabs.com>
Co-authored-by: Sam Harwell <sam@tunnelvisionlabs.com>
sharwell
approved these changes
Jan 3, 2022
Forgind
approved these changes
Jan 3, 2022
Contributor
Forgind
left a comment
There was a problem hiding this comment.
This would currently break MSBuild if merged alongisde ghogen's PR, but hopefully that one will be fixed soon.
Contributor
elachlan
commented
Jan 7, 2022
elachlan
commented
Jan 7, 2022
| /// resource), not necessarily the assembly version. | ||
| /// If you want the assembly version, use Constants.AssemblyVersion. | ||
| /// This is not the <see cref="P:Microsoft.Build.BuildEngine.ToolsetCollection.ToolsVersions*">ToolsetCollection.ToolsVersions</see>. | ||
| /// This is not a <see cref="Toolset"/>. |
Member
There was a problem hiding this comment.
I think this is the modern equivalent:
Suggested change
| /// This is not a <see cref="Toolset"/>. | |
| /// This is not the <see cref="Toolset.ToolsVersion"/>. |
Co-authored-by: Rainer Sigwald <raines@microsoft.com>
Forgind
approved these changes
Jan 10, 2022
Contributor
Forgind
left a comment
There was a problem hiding this comment.
Failure looks like it's from one of the other analyzers: documentation beginning with a space.
Contributor
Author
|
Is there anything waiting to be done in this? |
rainersigwald
approved these changes
Feb 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #7174
https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/CA1200