Add .NET Core solution open to OptProf training scenarios#6758
Conversation
rainersigwald
left a comment
There was a problem hiding this comment.
I see it's called OpenClose test. Do we have a scenario covering a basic build of this project type?
Forgind
left a comment
There was a problem hiding this comment.
Sounds like a nice win. Is there somewhere I can look at the solution?
Surprisingly, no. I wasn't able to find one that we could just reference. I think it would make perfect sense to add it as well (under src\Tests\MSBuild in the VS repo, for example). Another potential change I'm tracking is making our assemblies use full (as opposed to partial) NGEN, so even code that's not covered in training scenarios is pre-compiled.
Absolutely, the test uses this asset: internal link. |
Fixes #6067
Context
There is a few dozen milliseconds worth of avoidable JITting happening in MSBuild assemblies on VS solution open. The respective methods are considered cold and not part of our NGEN images because they are not executed by current training scenarios.
Changes Made
Added an additional scenario to specifically cover .NET Core projects.
Testing
Ran the OptProf pipeline with this change and then Perf.DDRITs with a build optimized using the resulting optimization data.