Skip to content

Remove depenency on MemberRef Parent of a custom attribute constructor being a TypeReference#6735

Merged
rokonec merged 1 commit intodotnet:mainfrom
davidwrighton:fix_6734
Aug 11, 2021
Merged

Remove depenency on MemberRef Parent of a custom attribute constructor being a TypeReference#6735
rokonec merged 1 commit intodotnet:mainfrom
davidwrighton:fix_6734

Conversation

@davidwrighton
Copy link
Member

@davidwrighton davidwrighton commented Aug 4, 2021

Fixes #6734

Also fixes #6730

This fixes #6734 in my scenario.

@rainersigwald
Copy link
Member

rainersigwald commented Aug 5, 2021 via email

@davidwrighton
Copy link
Member Author

@rainersigwald Thank you for the advice, with this fix, the issue is fixed.

@davidwrighton davidwrighton requested review from hoyosjs and ladipro and removed request for hoyosjs August 5, 2021 22:26
Copy link
Contributor

@Forgind Forgind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@ladipro ladipro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ladipro ladipro added the merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now. label Aug 6, 2021
@rokonec rokonec merged commit 6ca8616 into dotnet:main Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now.

Projects

None yet

5 participants